feat: log up-to-date when single entry #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaggacao
force-pushed
the
feat/feedback-on-single-item
branch
2 times, most recently
from
8445e17
to
f221b7d
Compare
lilydjwg
requested changes
Mar 9, 2024
nvchecker/core.py
Outdated
| oldvers: VersData, r: Result, | ||
| oldvers: VersData, | ||
| r: Result, | ||
| log_noop: bool, |
There was a problem hiding this comment.
We need a better name for it. Maybe verbose since verbosity is indeed increased.
nvchecker/core.py
Outdated
Comment on lines
388
to
392
| if log_noop: | ||
| # provide visible user feedback if it was the only entry | ||
| logger.info('up-to-date', name=r.name, version=r.version, url=r.url) | ||
| else: | ||
| logger.debug('up-to-date', name=r.name, version=r.version, url=r.url) |
There was a problem hiding this comment.
You can use logger.log(level, ...) to avoid duplicate code.
lilydjwg
force-pushed
the
feat/feedback-on-single-item
branch
from
1ce6324
to
887665d
Compare
this ensures the newver file keeps untouched records
lilydjwg
force-pushed
the
feat/feedback-on-single-item
branch
from
887665d
to
9dd7fb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
discussion in #253 (comment)