Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added notification off docs #196

Merged
merged 6 commits into from
Mar 4, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions content/en/meshmap/designer/comments/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,28 @@ After a comment has been resolved, there might be situations where you need to r

<img src="./comments-unresolved.gif" alt="Unresolving comments in designer" width="600">

### Mute Comment Notifications
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, Akshay. Looks great.

Little suggestion: instead of having a separate section for this feature, why don't we add it to the "enable email notifications" section since they're related? Having a subheading about muting comment notifications under a heading on Tips for using comments as a design review tool seems counter-intuitive. Plus the content looks like a rewrite of the "enable email notifications" section so it's kind of repetitive.

The image looks great as well. Well done.


Customize your notification preferences to mute email notifications for comments on your design. With notifications for new comments silenced, you won't receive email notifications for new comments on your design. This can be useful if you want to temporarily pause notifications or reduce email clutter.

**What Muting Affects:**

- *Muted Design's Comment Thread:* This includes all subsequent replies within the same thread, whether directed at you or not.
- *Your Mentions:* You won't receive email alerts when someone mentions you in the muted design's comment thread.

**What Muting Doesn't Affect:**

- *Mentions in Other Designs:* You'll still be notified if someone mentions you in new or existing comment threads on other designs in your portfolio.
- *New Comment Threads:* Muting only applies to the specific comment thread it's activated on. New threads on the same design will trigger notifications as usual.

{{< alert title="Remember">}}
- While email alerts are muted, you can still access and view all comments on the design at any time.
- You'll never miss an important mention, as notifications for mentions outside the muted thread remain active.
{{< /alert >}}


<img src="./comment-notificationBell.png" alt="Turn Off notification from comments in designer" style="width:auto">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please place the image above What Muting Affects:


## Best Practices for Effective Design Reviews

### Be specific and actionable
Expand Down
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Two issues:

  1. poor quality screenshot.
  2. let's have pleasant, positive sample interactions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading