added notification off docs #196
Conversation
Signed-off-by: captain-Akshay <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@nwanduka., how did @captain-Akshay do? |
There was a problem hiding this comment.
@Yashsharma1911 , it's unclear according to this documentation whether this silence notifications button is a per comment silencer for a silencer for all comments... in a design or for my entire user account? Does this setting only affect me or does it affect other users of this design? Do I need to own the design in order to use this?
What happens if I muted, people make comments, I unmute will I receive historical notifications for comments that were placed while I had silence on?
There was a problem hiding this comment.
Thanks for this. Two issues:
- poor quality screenshot.
- let's have pleasant, positive sample interactions.
| @@ -68,6 +68,12 @@ After a comment has been resolved, there might be situations where you need to r | |||
|
|
|||
| <img src="./comments-unresolved.gif" alt="Unresolving comments in designer" width="600"> | |||
|
|
|||
| ### Mute Comment Notifications | |||
|
|
|||
| Customize your notification preferences to mute emails for comments on your design. When this feature is enabled, you won't receive email notifications for new comments on your design. This can be useful if you want to temporarily pause notifications or reduce email clutter. Follow the steps below to mute comment notifications | |||
There was a problem hiding this comment.
You don't "mute emails", you "mute notifications" or "mute email notifications".
| @@ -68,6 +68,12 @@ After a comment has been resolved, there might be situations where you need to r | |||
|
|
|||
| <img src="./comments-unresolved.gif" alt="Unresolving comments in designer" width="600"> | |||
|
|
|||
| ### Mute Comment Notifications | |||
|
|
|||
| Customize your notification preferences to mute emails for comments on your design. When this feature is enabled, you won't receive email notifications for new comments on your design. This can be useful if you want to temporarily pause notifications or reduce email clutter. Follow the steps below to mute comment notifications | |||
There was a problem hiding this comment.
"with this feature enabled"... no. Please change to "With notifications for new comments silenced, ..."
There was a problem hiding this comment.
"you won't receive email notifications for new comments on your design." - what about existing comments and new threaded added?
@captain-Akshay, buckle down a description of the logic here - describe the behavior in various scenarios / under various conditions.
|
@captain-Akshay you can do better. And I expect you to do better. |
|
@nwanduka, it seems that you might have missed this review. The comments that I've made could / should be made by you as either the first reviewer or the writer of this PR. |
| @@ -68,6 +68,12 @@ After a comment has been resolved, there might be situations where you need to r | |||
|
|
|||
| <img src="./comments-unresolved.gif" alt="Unresolving comments in designer" width="600"> | |||
|
|
|||
| ### Mute Comment Notifications | |||
There was a problem hiding this comment.
Thanks for working on this, Akshay. Looks great.
Little suggestion: instead of having a separate section for this feature, why don't we add it to the "enable email notifications" section since they're related? Having a subheading about muting comment notifications under a heading on Tips for using comments as a design review tool seems counter-intuitive. Plus the content looks like a rewrite of the "enable email notifications" section so it's kind of repetitive.
The image looks great as well. Well done.
I started a review and didn't realize I hadn't submitted it. I was honestly confused when I kept getting the request to review the PR. All the while I was thinking to myself, "is no one else seeing the comment I left?" Now I know why 🤦🏽♀️. Anyway, lesson learned. |
These are good questions and yes, this doc doesn't answer all of these questions, @captain-Akshay I'll help here with updating this doc |
|
@Yashsharma1911 @captain-Akshay @nwanduka added draft label please remove this when your finished with your changes |
|
|
|
// @Yashsharma1911 let me know if i missed anything |
Signed-off-by: captain-Akshay <[email protected]>
|
@VictoryWekwa @iArchitSharma good to go? |
Signed-off-by: captain-Akshay <[email protected]>
| {{< /alert >}} | ||
|
|
||
|
|
||
| <img src="./comment-notificationBell.png" alt="Turn Off notification from comments in designer" style="width:auto"> |
There was a problem hiding this comment.
can you please place the image above What Muting Affects:
Signed-off-by: Archit Sharma <[email protected]>
Notes for Reviewers
This PR fixes #
Signed commits