Change metrics names

[assafad]

What this PR does / why we need it:
This PR changes SSP metrics names, in order to meet the metrics naming conventions, and to successfully pass the metrics names linter.

Which issue(s) this PR fixes:
https://issues.redhat.com/browse/CNV-30668

Release note:

Deprecation notice for the metrics listed in the PR. They will be removed in this release. Please update your systems to use the new metrics names.
ssp_operator_reconciling_properly -> kubevirt_ssp_operator_reconcile_succeeded
kubevirt_ssp_num_of_operator_reconciling_properly -> kubevirt_ssp_operator_reconcile_succeeded_aggregated
total_rejected_vms -> kubevirt_ssp_template_validator_rejected_total
kubevirt_ssp_rejected_vms_total -> kubevirt_ssp_template_validator_rejected_increase
total_restored_common_templates -> kubevirt_ssp_common_templates_restored_total
kubevirt_ssp_common_templates_restored_total -> kubevirt_ssp_common_templates_restored_increase
Kubevirt_ssp_template_validator_up_total -> kubevirt_ssp_template_validator_up
Kubevirt_ssp_operator_up_total -> kubevirt_ssp_operator_up

[assafad]

@sradco, @0xFelix can you please review?

[assafad]

/hold

[0xFelix]

/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [0xFelix]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sradco]

/lgtm

[assafad]

/unhold

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
8.2% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[sradco]

/lgtm

[assafad]

@0xFelix Can we merge this one?

[0xFelix]

Merged manually to workaround failing reviewers automation

[akrejcir]

@assafad, The Jira ticket is targeted to 4.14. Do you want to backport this to release-v0.18?

[assafad]

/cherry-pick release-v0.18

[kubevirt-bot]

@assafad: #643 failed to apply on top of branch "release-v0.18":

Applying: Change metrics names
Using index info to reconstruct a base tree...
M	controllers/ssp_controller.go
A	tools/prom-metrics-collector/metrics_collector.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): tools/prom-metrics-collector/metrics_collector.go deleted in HEAD and modified in Change metrics names. Version Change metrics names of tools/prom-metrics-collector/metrics_collector.go left in tree.
Auto-merging controllers/ssp_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Change metrics names
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.