Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.18] Change metrics names #656

Merged

Conversation

assafad
Copy link
Contributor

@assafad assafad commented Aug 15, 2023

Manual cherrypick of #643.

Release note:

Deprecation notice for the metrics listed in the PR. They will be removed in this release. Please update your systems to use the new metrics names.
ssp_operator_reconciling_properly -> kubevirt_ssp_operator_reconcile_succeeded
kubevirt_ssp_num_of_operator_reconciling_properly -> kubevirt_ssp_operator_reconcile_succeeded_aggregated
total_rejected_vms -> kubevirt_ssp_template_validator_rejected_total
kubevirt_ssp_rejected_vms_total -> kubevirt_ssp_template_validator_rejected_increase
total_restored_common_templates -> kubevirt_ssp_common_templates_restored_total
kubevirt_ssp_common_templates_restored_total -> kubevirt_ssp_common_templates_restored_increase
Kubevirt_ssp_template_validator_up_total -> kubevirt_ssp_template_validator_up
Kubevirt_ssp_operator_up_total -> kubevirt_ssp_operator_up

Signed-off-by: assafad <[email protected]>
@assafad
Copy link
Contributor Author

assafad commented Aug 15, 2023

/cc @akrejcir

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@akrejcir
Copy link
Collaborator

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 16, 2023
@kubevirt-bot kubevirt-bot merged commit 0c2e035 into kubevirt:release-v0.18 Aug 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants