Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to ignore the Match directive #65

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

iamFrancescoFerro
Copy link

@iamFrancescoFerro iamFrancescoFerro commented Jul 17, 2024

This PR tries to make #6 less of an issue.

The go-git-v5 lib uses your nice ssh parser however in Alma 8/9 and most of RHEL there is this Match directive in the default ssh config and it completely breaks all the git operation in these OSes

While someone brave enough makes the implementation for parsing the Match I thought ignoring it would be enough.

Ideally we shouldn't be passing so many params to functions but I didn't want to refactor to much stuff.

After this PR is merged you could ignore the directive like this:

ssh_config.DefaultUserSettings.IgnoreMatchDirective = true

This

config.go Outdated Show resolved Hide resolved
@quike
Copy link

quike commented Jul 17, 2024

@kevinburke could you take a look whenever you have a chance? thanks

@iamFrancescoFerro
Copy link
Author

iamFrancescoFerro commented Jul 18, 2024

We can't even use the go mode replace because of this
https://github.com/src-d/go-git/blob/master/plumbing/transport/ssh/common.go#L23

we can't override

@oneirocosm
Copy link

I was just testing this out in my fork of the repo and found a bug. Line 431 of config.go also needs to check the ignoreMatchDirective flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants