Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Match #6

Open
kevinburke opened this issue Apr 23, 2017 · 6 comments
Open

Implement Match #6

kevinburke opened this issue Apr 23, 2017 · 6 comments

Comments

@kevinburke
Copy link
Owner

kevinburke commented Apr 23, 2017

I'm worried I'm not smart enough to implement Match exec properly; it seems like a security risk.

@kevinburke
Copy link
Owner Author

kevinburke commented May 24, 2017

Punting on this for the moment, the specification is rather complicated

@Mech45
Copy link

Mech45 commented Oct 12, 2018

Hey, so today it raised an error when he finds a "Match" directive pattern, maybe can we just pass through it without raise anything ?
Thanks for your package by the way :)

@cv
Copy link

cv commented Mar 7, 2019

@kevinburke would you consider a PR that made it an option to skip Match exec blocks entirely? I don't need to parse those at the moment, but the rest of the ssh config is useful to me.

@gromero
Copy link

gromero commented Jul 30, 2021

@kevinburke ping (about @cv question). I think it's still valid and needs to be handled. Thanks.

@quite
Copy link

quite commented May 15, 2024

@kevinburke ping (about @cv question). I think it's still valid and needs to be handled. Thanks.

Yes I agree. While #45 (#38) does help a little, we loose a lot of functionality that is provided by the UserSettings type. So I think a way to skip Match lines at a higher level would be good, as long as Match is unsupported and results in failure to parse config -- a bool in UserSettings?

@iamFrancescoFerro
Copy link

@quite @kevinburke

Would that be ok ?

#65

Luap99 added a commit to Luap99/libpod that referenced this issue Nov 14, 2024
The new ssh_Config feature doesn't work on my system because the lib
fails to parse configs using Match[1]. However Fedora and RHEL based
distros seem to ship /etc/ssh/ssh_config.d/50-redhat.conf which contains
a Match line thus it always fails to parse and never uses the proper
values from my home dir config.

[1] kevinburke/ssh_config#6

Signed-off-by: Paul Holzinger <[email protected]>
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/podman that referenced this issue Nov 18, 2024
The new ssh_Config feature doesn't work on my system because the lib
fails to parse configs using Match[1]. However Fedora and RHEL based
distros seem to ship /etc/ssh/ssh_config.d/50-redhat.conf which contains
a Match line thus it always fails to parse and never uses the proper
values from my home dir config.

[1] kevinburke/ssh_config#6

Signed-off-by: Paul Holzinger <[email protected]>
Luap99 added a commit to Luap99/libpod that referenced this issue Nov 19, 2024
The new ssh_Config feature doesn't work on my system because the lib
fails to parse configs using Match[1]. However Fedora and RHEL based
distros seem to ship /etc/ssh/ssh_config.d/50-redhat.conf which contains
a Match line thus it always fails to parse and never uses the proper
values from my home dir config.

[1] kevinburke/ssh_config#6

Signed-off-by: Paul Holzinger <[email protected]>
(cherry picked from commit 8a5ec2c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants