Add checks for better map assertions #5
Conversation
jzbrooks
force-pushed
the
map-assertions
branch
from
b255147
to
394c8cf
Compare
|
@evant, if you have some time to sanity check this conceptually, I'd appreciate it! |
| 0 errors, 1 warnings""", | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
Do you care about usages like map.entries.map { it.key }?
There was a problem hiding this comment.
Maybe. Have you seen that call before in the wild?
It strikes me as odd to iterate the entries to read a set that the map is probably already maintaining internally, but if people do that for whatever reason…
There was a problem hiding this comment.
Ha, honestly I'm not sure; I was mostly trying to find edge cases related to keys.
I think I've written it before, but probably incorrectly 🙂
There was a problem hiding this comment.
I'm going to merge this, but I created #11 to track interest in something like that over time. I explained a little of my rationale there.
Fixes #3