Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect obfuscated map reads #11

Open
jzbrooks opened this issue Jan 27, 2024 · 2 comments
Open

Detect obfuscated map reads #11

jzbrooks opened this issue Jan 27, 2024 · 2 comments

Comments

@jzbrooks
Copy link
Owner

Tracking a list of obfuscated map reads that might be valuable to consider in the map assertion checks:

  • map.entries.map { it.key }

Ref #5

@jzbrooks
Copy link
Owner Author

I think the question becomes where do we stop with trying to figure out all possible obfuscation cases. People can do silly things to avoid detection, but I lean toward the lint checks assuming competence & good faith consideration of alternatives. Trying to cover strange cases can tend to suggest that the check covers all cases. That's great when possible, but if we can't be sure that we cover all the strange cases, it might be better to cover the normative cases (really cases that are the proper use of a particular API surface) and leave the strange cases for either code review or lint checks purpose built to smoke out odd/bad uses.

@jzbrooks
Copy link
Owner Author

This originally came from #5 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant