Invalid state when node is deleted in a different session. #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the Doctrine ORM, it seems if I perstist an Entity, delete it directy from the database, then refresh it - nothing happens and it is still "managed" If I then re-persist it, it is not persisted. Strange .. |
| $this->session->refresh(false); | ||
|
|
||
| // throws PathNotFoundException | ||
| $article->getProperty('foo'); |
There was a problem hiding this comment.
this is expected behaviour. the node was deleted so accessing the property should throw an exception.
There was a problem hiding this comment.
indeed, I was just checking what would happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have encountered problems with the new DoctrinePHPCRBundle when it shuts down the kernel. It calls "clean" on the document manager and then logs out of the session(s).
The problem is that calling "clean" invokes a
refresh(false)and in our test cases it may be that some of the nodes managed in the current kernel have been deleted from storage in another, so our system explodes with:when the kernel is shutdown.
I think that in this case nodes should be de-registered (and so accessing them would throw a "node deleted" error) -
if you
refresh($keepChanges = false)and this is the case, it means that you may encounter this error later rather than sooner (mostly never) - not sure if that is better or worse tbh.We could also address this in the Bundle somehow.