Remove hack for PHPCR-ODM 1.2

[dantleech]

We upgraded (or will shortly upgrade to) PHPODM 1.3; we should remove these lines: https://github.com/sulu-io/sulu/blob/7bbdcd18d50a320ad2c7e6286138a1b8a11d7901/src/Sulu/Bundle/CoreBundle/DependencyInjection/SuluCoreExtension.php#L44

[dantleech]

As far as I can see this issue is worked around in the PHPCR bundle, the fix is currently unreleased:
doctrine/DoctrinePHPCRBundle@10105dc

I don't think this is urgent however. /cc @lsmith77 @danrot

[danrot]

@dantleech The link you've posted here seems to be released in 1.3. Does this commit contain the fix?

[dantleech]

Yeah, my bad. I was looking at the branches and not the tags. We can indeed upgrade to 1.3

[danrot]

Had to reintroduce the hack, because the behat tests were failing with the new phpcr bundle...

[dantleech]

We could either wait for jackalope/jackalope-doctrine-dbal#323 or logout of the session / shutdown our kernel before making the web requests with Behat.

[danrot]

I would say we have no hurry in fixing this issue, so we could wait for the fix.

[alexander-schranz]

@danrot can we remove this?

[danrot]

I have no idea, the last time I tried the behat tests were failing... But if that is the only thing failing we might be able to remove it in Sulu 2.0.

[danrot]

I somehow get the feeling that this won't be fixed... Therefore going to close it. I think the comment in the code is good enough.