Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(support): add blocks (Search, Table, Sidebar) to support pages #346

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

proeung
Copy link

@proeung proeung commented Oct 2, 2023

Issue

Fixes - https://merative.atlassian.net/browse/MERATIVE-772

Fixes #256
Fixes #280
Fixes #281

Description

New

  • New import script specifically modified for Support pages
  • Added a new search block (/blocks/search) to filter and search across any pages (based on a path filter)
  • Sidebar functionality block (/blocks/right-nav)
  • Added a block called Table (/blocks/table) to mange and style table content that are used across Curam support pages.

Changed

  • Moved existing import.js script to import-docs.js as that was used to import PDF doc pages

Testing Previews

With Table and Sidebar/ Left Nav blocks

Before: https://main--merative2--hlxsites.hlx.page/support/spm/flashes/configure-target-issue-jdbc-connection
After: https://fix-772-support-pages--merative2--proeung.hlx.page/support/spm/flashes/configure-target-issue-jdbc-connection

With Search block

Before: https://main--merative2--hlxsites.hlx.page/support/spm/support-articles
After: https://fix-772-support-pages--merative2--proeung.hlx.page/support/spm/support-articles

Checkout SPM/Curam support directory for more example: https://merative.sharepoint.com/:f:/s/Merative.comWebsite/EtHhQ_gRl7tKuQ6Ja0rGgrIBQMEIvWotpd7kSpnSdV6sUQ?e=T96cnb

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 2, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 2, 2023

Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 10, 2023

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 12, 2023

@keith-kaplan keith-kaplan merged commit 44fd141 into hlxsites:main Oct 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Stakeholders sign off Merative team sign off
Projects
None yet
2 participants