feat(support-pages): Add a new import script #275
Conversation
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
proeung
changed the title
There was a problem hiding this comment.
@amol-anand Thanks for adding this import-support.js to the repo for future reference!
A couple of notes/questions
- I can see in the Sharepoint directory that you've copied the imported docs to the
/support. Is there a way to bulk publish these pages once we're ready to switch the routing from AEM to Franklin? @keith-kaplan Do we have a plan to reach out to certain stakeholders regarding this migration? Just wanted to ensure folks are aware that they will need to switch their content entry process from AEM to Franklin. - Some support pages include a breadcrumb, sidebar, styling for the tables, etc. For these pages, we might need to adjust the import script to look for these elements and convert them into blocks (eg. Breadcrumb as a fragment). Let me know how you'd like to tackle this portion of the support page migration effort. I can create a separate issue to handle the creation and styling of some of these blocks/components.
AEM version: https://www.merative.com/support/spm/flashes/configure-target-issue-jdbc-connection
Franklin version: https://main--merative2--hlxsites.hlx.page/support/spm/flashes/configure-target-issue-jdbc-connection
|
I haven't had that conversation yet. I'd like to this to be in a bit better shape to show them. I know som of the sidebar features are controlled by shortcodes/fragments in AEM. We'll need to look into having that implemented. |
|
@keith-kaplan Yeah, that makes sense. Looks like the breadcrumbs and sidebar (document info) will need to be treated as block fragments so that they're re-usable on other pages. |
Yes. Using the sidekick from sharepoint folder level we can select multiple files and then preview and publish.
Agreed. Let's create two separate issues for the sidebar and breadcrumb. Once those are built, then we can modify this script to include them if they exist on the page. I would keep this PR open until that is completed. |
|
@amol-anand Here are the two issues related to the support migration work. Also, @keith-kaplan feel free to adjust the description if there are some details that are missing. |
|
|
|
|
@amol-anand Any update on the remaining work for the Support pages migration? Also, are you planning on opening a new PR or working within this one? |
|
I'm going to work in this same PR to resolve the two outstanding issues. Something I am looking to work on this week. |
|
|
|
There was a problem hiding this comment.
Looks good overall! @keith-kaplan and I just have some follow up changes that we think would be good to implement in this migration effort.
Let me know if you have availability to address these feedback.
| .section.breadcrumb-container > div.breadcrumb-wrapper { | ||
| padding: unset; | ||
| width: 100%; | ||
| background-color: #F3F1ED; |
There was a problem hiding this comment.
| background-color: #F3F1ED; | |
| background-color: var(--neutral-40); |
Let's add this neutral 40% hex color variable to our style.css - --neutral-40: F3F1ED;
| /* Right Nav CSS */ | ||
|
|
||
| @media only screen and (min-width: 1200px) { | ||
| main .section.right-nav-container > div { | ||
| width: unset; | ||
| } | ||
|
|
||
| .section.right-nav-container { | ||
| position: relative; | ||
| display: grid; | ||
| grid-template-columns: 3fr 1fr; | ||
| width: var(--section-width-desktop); | ||
| margin: 0 auto; | ||
| } | ||
|
|
||
| .section.right-nav-container > *:not(.right-nav-wrapper) { | ||
| grid-column-start: 1; | ||
| } | ||
|
|
||
| .section.right-nav-container > .right-nav-wrapper { | ||
| grid-column-start: 2; | ||
| grid-row-start: 1; | ||
| padding-top: var(--spacer-layout-07); | ||
| margin-left: 8%; | ||
| } | ||
| } |
There was a problem hiding this comment.
Nitpicking: I think we should rename this block right-nav to sidebar. "Right Nav" implies that it's navigational content, however, this is more supplemental info.
There was a problem hiding this comment.
feel free to change the name. whatever makes more sense for you
| @@ -0,0 +1,76 @@ | |||
| /* Search Block CSS */ | |||
There was a problem hiding this comment.
Note: We'll clean up some of the stylings to ensure that we're using the spacings and etc from the design specs.
| docInfo.remove(); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we add a check to the import script to map additional fields like the Category, Parent, and Product Family to the metadata section, especially for Curam/SPM support pages?
For instance, if the page is /support/spm/* or /support/curam/*, map the following metadata field to the sharepoint doc structure.
Category - Health and human services
Parent - Social Program Management
Product Family - Social Program Management Top
@keith-kaplan Let me know if there are other metadata fields that you'd like to add as well.
There was a problem hiding this comment.
Yes we can do this in the import code - BUT we can also do this via bulk metadata especially since it is limited by path.
Putting it in the individual page metadata would imply that authors should be changing this (which I don't think is the use-case here since this is all analytics related IIRC)?
proeung
added
Needs Stakeholders sign off
|
@proeung added a few more details for the metadata rows that need to be added. For all of the SPM Pages
For all of the Integrated Care Pages
|
proeung
added
On-Hold
proeung
added
🛠️ fix needed
and removed
On-Hold
|
Closing this PR in favor of this new one (#346) that resolves all merge conflicts and include missing styles and code clean up. |
Issue
Fixes #256
Fixes #280
Fixes #281
Description
Added a new import script to import Support pages to Franklin
New
Changed
Testing Instruction
Before: https://main--merative2--hlxsites.hlx.page/support/micromedex-product-support-details
After: https://support-pages-import--merative2--hlxsites.hlx.page/support/micromedex-product-support-details
After: https://support-pages-import--merative2--hlxsites.hlx.page/support/spm/flashes/configure-target-issue-jdbc-connection
After: https://support-pages-import--merative2--hlxsites.hlx.page/support/spm/support-articles
In Progress