Allow forcing localhost when not using Ember-CLI to serve project #22
+13
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #13 -
We don't use ember-cli to serve our dist/ directory. We also use a non-standard local hostname.
This change adds a
liveReloadForceLocalhost
option to force the addon to expect the livereload script on a fully-qualified localhost URL (rather than a relative path).Ember-CLI's
baseURL
andport
options are respected.It could be further generalized to be more customizable, but my assumption is that CLI will really only be used on localhost. Since there's already a semi-hardcode (
location.hostname || 'localhost'
), this seems reasonable to me.To use,
Seems to be working for us - let me know what you think!
Thanks,
-david