Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify livereload injection by removing the script. #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simplify livereload injection by removing the script. #23

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 11, 2015

This is one approach to solving #22 and #13.

This PR removes the dynamically generated script, and loads it from the livereload server directly.

It uses new configuration variable options.liveReloadHost (implemented in ember-cli/ember-cli@7a6a47e) and will take into account options.ssl to avoid mixed content warnings.

This is one approach at solving #22 and #13.

This PR removes the dynamically generated script, and
loads it from the livereload server directly.

It introduces a new configuration variable `options.liveReloadHost`
and will take into account `options.ssl` to avoid mixed content
warnings.
@ghost
Copy link
Author

ghost commented Jun 11, 2015

If we also wanted to shrink the CSP list, we could resurrect the app.use to serve livereload.js ourselves (or proxy to tinylr's server). We'd still have the ability to set the livereload server and hostname that way, since it accepts host and port options on the query string. In that case, you simply call it like this:

http://emberhost/livereload.js?snipver=1&host=liveReloadHost&port=liveReloadPort

@ghost
Copy link
Author

ghost commented Jul 14, 2015

ping?

@jsmecham
Copy link

I like this approach. Any life on this?

@Kledal
Copy link

Kledal commented Aug 11, 2016

I like this approach too and we are currently using this 👍

@lukemelia
Copy link
Contributor

I'm in favor of an approach like this and would volunteer to rebase if the PR would be welcomed and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants