make sure assertEventsEqual() actually has events to test #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herringway
force-pushed
the
fix-emitter-tests
branch
2 times, most recently
from
814dec4
to
a2b0f95
Compare
Herringway
force-pushed
the
fix-emitter-tests
branch
from
a2b0f95
to
5e0bdad
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #316 +/- ##
==========================================
+ Coverage 95.13% 95.29% +0.15%
==========================================
Files 29 29
Lines 4505 4505
==========================================
+ Hits 4286 4293 +7
+ Misses 219 212 -7
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out a big portion of the test suite wasn't actually running due to Loader.parse() not returning a forward range. Note that the test suite now fails, so this probably shouldn't be merged just yet....