Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't skip explicit str tags when emitting #317

Merged

Conversation

Herringway
Copy link
Member

@Herringway Herringway commented Sep 18, 2023

Fixes an issue uncovered by #316

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #317 (c406a81) into master (a914d23) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #317   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files          29       29           
  Lines        4505     4505           
=======================================
  Hits         4286     4286           
  Misses        219      219           
Files Changed Coverage Δ
source/dyaml/emitter.d 95.39% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a914d23...c406a81. Read the comment docs.

@Herringway Herringway merged commit 05cdebf into dlang-community:master Sep 18, 2023
8 checks passed
@Herringway Herringway deleted the dont-skip-explicit-str-tag branch September 18, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant