Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stacrs #28293

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add stacrs #28293

wants to merge 5 commits into from

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Nov 20, 2024

A no-dependency Python package for STAC, using Rust under the hood! Repo at https://github.com/stac-utils/stac-rs

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

A no-dependency Python package for STAC, using Rust under the hood! Repo at https://github.com/stac-utils/stac-rs
Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/stacrs/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/stacrs/recipe.yaml:

  • ❌ The top level meta key schema_version is unexpected
  • ❌ There are 1 too many lines. There should be one empty line at the end of the file.

For recipes/stacrs/recipe.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >=${{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

Silence conda-forge linter messag: `The top level meta key schema_version is unexpected`
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/stacrs/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/stacrs/recipe.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >=${{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/stacrs/recipe.yaml) and found it was in an excellent condition.

@weiji14
Copy link
Member Author

weiji14 commented Nov 20, 2024

Getting this build error:

+ cargo-bundle-licenses --format yaml --output THIRDPARTY.yml
Error: `cargo metadata` exited with an error: error: package `$SRC_DIR/crates/cli` is listed in default-members but is not a member
for workspace at $SRC_DIR/Cargo.toml.

I downloaded the sdist (stacrs-0.2.2.tar.gz) from https://pypi.org/project/stacrs/0.2.2/#files, and saw that the Cargo.toml at has these lines:

[workspace]
resolver = "2"
members = ["python"]
default-members = [
    "crates/api",
    "crates/cli",
    "crates/core",
    "crates/extensions",
]

These appear to be derived from https://github.com/stac-utils/stac-rs/blob/d13c0f474c1e3b2fc3854bdf60f10608b273c689/Cargo.toml#L13-L18. The 'crates/cli` folder is indeed missing in the sdist, so need to see how to handle this... See related thread at PyO3/maturin#2046

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants