Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose third party methods in biscuit-python #31

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Expose third party methods in biscuit-python #31

wants to merge 2 commits into from

Commits on Nov 24, 2024

  1. biscuit-python: bump pyo3 to 0.23.1 

    This is mostly just following the upgrade guide here: https://pyo3.rs/v0.22.0/migration.html

I chose to not go directly to 0.23.1 because (selfishly) we're on 0.22.6 and
don't want to wait on our upgrade.  Normally these python bindings would be
independent of what other modules in our codebase are doing, but in this case
I'm trying to build a single rust package with biscuit-python + bindings to our
own layer on top of biscuits, so they need to use the same pyo3 version.

Test Plan:
    @adamh-oai
    adamh-oai committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    706af0c View commit details
    Browse the repository at this point in the history

  2. Expose third party methods in biscuit-python 

    Since `create_block` consumes `self`, I had to clone the `ThirdPartyRequest`
here.  Not sure if there's a better way to handle it?
    @adamh-oai
    adamh-oai committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    f475c95 View commit details
    Browse the repository at this point in the history