Expose third party methods in biscuit-python #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly just following the upgrade guide here: https://pyo3.rs/v0.22.0/migration.html I chose to not go directly to 0.23.1 because (selfishly) we're on 0.22.6 and don't want to wait on our upgrade. Normally these python bindings would be independent of what other modules in our codebase are doing, but in this case I'm trying to build a single rust package with biscuit-python + bindings to our own layer on top of biscuits, so they need to use the same pyo3 version. Test Plan:
Since `create_block` consumes `self`, I had to clone the `ThirdPartyRequest` here. Not sure if there's a better way to handle it?
|
This was accidentally submitted and hasn't been tested yet, FYI. |
|
sure, it looks like it depends on #30 anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
create_blockconsumesself, I had to clone theThirdPartyRequesthere. Not sure if there's a better way to handle it?