Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master] Generate new typedesc instruction for record and tuple when type descriptor resolving #43596

Open
wants to merge 101 commits into
base: master
Choose a base branch
from

Commits on Aug 16, 2024

  1. Reorder top level nodes

    chiranSachintha authored and rdulmina committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    ba768a7 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Access annotations from typedesc

    chiranSachintha authored and rdulmina committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    5dc8900 View commit details
    Browse the repository at this point in the history
  2. Update tuple equality check

    chiranSachintha authored and rdulmina committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    a6906f0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f76ac3e View commit details
    Browse the repository at this point in the history
  4. Generate newTypedesc instruction

    chiranSachintha authored and rdulmina committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    54c478e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    962d8f9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2df1bbc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e0e0131 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    935f960 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8d561b6 View commit details
    Browse the repository at this point in the history
  10. Update toString logic

    chiranSachintha authored and rdulmina committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    4317260 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    604fb13 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    84d4d65 View commit details
    Browse the repository at this point in the history
  13. Refactor logic

    chiranSachintha authored and rdulmina committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    2947f76 View commit details
    Browse the repository at this point in the history
  14. Get implied type of typedesc

    chiranSachintha authored and rdulmina committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    b14ec39 View commit details
    Browse the repository at this point in the history
  15. Revert "Remove closure field and update TypedescValueImpl construct…

    …ors"
    
    This reverts commit 962d8f9.
    rdulmina committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    d470345 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Revert "Revert "Remove closure field and update TypedescValueImpl c…

    …onstructors""
    
    This reverts commit d470345.
    rdulmina committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    77d0b24 View commit details
    Browse the repository at this point in the history
  2. Remove unused imports

    rdulmina committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    71d37a2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1207d10 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bb14e26 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e7ff5d2 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Refactor BIRGen changes

    rdulmina committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b2a7e21 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Add closures before the dependent node in the top-level node list

    Add closures before the dependent node in the top-level node list in `ClosureGenerator.java`
    rdulmina committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    deeac52 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f6f591c View commit details
    Browse the repository at this point in the history
  3. Exclude field generation for typedesc

    Exclude field generation for typedesc when generating fields for user defined types since those fields will be generated when visiting global variables
    rdulmina committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    e0bb977 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0cde6eb View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Configuration menu
    Copy the full SHA
    aaa3a9b View commit details
    Browse the repository at this point in the history
  2. Remove visitTypeDesc method

    rdulmina committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    28b3012 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Add typedesc statement before the var declaration

    Add typedesc statement before the var declaration in the init function body
    rdulmina committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    5e40d0d View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Configuration menu
    Copy the full SHA
    0924038 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Configuration menu
    Copy the full SHA
    11c0ffe View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Configuration menu
    Copy the full SHA
    3e12916 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Configuration menu
    Copy the full SHA
    077313b View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Undo test removal commit

    rdulmina committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5d22ed6 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Fix issue in different module var ref names

    Add var ref from different modules in the same package to `importedGlobalVarsDummyVarDcls`
    rdulmina committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7f545f9 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Refactor code

    rdulmina committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e2b2b3b View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Configuration menu
    Copy the full SHA
    2a9f99f View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Configuration menu
    Copy the full SHA
    1d66ee2 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Configuration menu
    Copy the full SHA
    1f88965 View commit details
    Browse the repository at this point in the history
  2. Generate typedesc for const literal type and intersection type

    Generate typedesc for const literal type if record or tuple and intersection type if the effective type is record or tuple. Also did some refactoring for BIRGen
    rdulmina committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ba08a23 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Configuration menu
    Copy the full SHA
    eb32a05 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b80968c View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Configuration menu
    Copy the full SHA
    f1ebb95 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Configuration menu
    Copy the full SHA
    f831aa0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7eaa889 View commit details
    Browse the repository at this point in the history
  3. Fix failing typedesc test

    rdulmina committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    5a97157 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5876754 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    68246cf View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Refactor BIRGen code

    rdulmina committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2aed9d2 View commit details
    Browse the repository at this point in the history
  2. Add extra diagnostic

    rdulmina committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    f412eb0 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. Configuration menu
    Copy the full SHA
    64caa3e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec8cc50 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Configuration menu
    Copy the full SHA
    a1c03fd View commit details
    Browse the repository at this point in the history
  2. Fix set of failing tests

    rdulmina committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    544c3e7 View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'upstream/master' into typeDesc-stmt

    # Conflicts:
    #	bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/TypeChecker.java
    #	bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/TypedescValueImpl.java
    #	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
    #	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/cyclefind/GlobalVariableRefAnalyzer.java
    #	tests/jballerina-unit-test/src/test/java/org/ballerinalang/nativeimpl/jvm/runtime/api/tests/Values.java
    #	tests/jballerina-unit-test/src/test/java/org/ballerinalang/nativeimpl/jvm/tests/VariableReturnType.java
    #	tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/bala/record/ClosedRecordTypeInclusionTest.java
    rdulmina committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    71dc4a9 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Configuration menu
    Copy the full SHA
    a89be92 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Update failing test

    rdulmina committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    1b5e0c9 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Configuration menu
    Copy the full SHA
    8f9056d View commit details
    Browse the repository at this point in the history
  2. Create typedesc for parent type before generating for nested types

    This is required to prevent passing large number of arguments for split functions generated via `LargeMethodSplitter.Java`. We need to pass the typedesc vars for inner types as arguments if they are defined before the parent typedesc var
    rdulmina committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    955e842 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Fix LargeMethodOptimizer after typedesc change

    LargeMethodOptimizer depends on the instruction order for new array and new structure. After generating single typedesc for all the occurences of the type and the instruction order is changed.
    rdulmina committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    f843a88 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Configuration menu
    Copy the full SHA
    79cb805 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6611e11 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Configuration menu
    Copy the full SHA
    810bcc6 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. Fix checkstyle

    rdulmina committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    4051715 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cf13824 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2024

  1. Fix checkstyle

    rdulmina committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    0f12202 View commit details
    Browse the repository at this point in the history
  2. Undo unwanted changes

    rdulmina committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    eaf64f9 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Configuration menu
    Copy the full SHA
    b969e8a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4a72178 View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'upstream/master' into typeDesc-stmt

    # Conflicts:
    #	bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/MapValueImpl.java
    #	compiler/ballerina-lang/spotbugs-exclude.xml
    #	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmSignatures.java
    #	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmValueGen.java
    #	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/optimizer/LargeMethodOptimizer.java
    #	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/split/types/JvmRecordTypeGen.java
    #	tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/record/ClosedRecordOptionalFieldsTest.java
    #	tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/record/OpenRecordOptionalFieldsTest.java
    #	tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/types/anydata/AnydataTernaryConvTest.java
    #	tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/types/typedesc/TypedescTests.java
    rdulmina committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    eec5836 View commit details
    Browse the repository at this point in the history
  4. Remove unused methods

    rdulmina committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    3ff9914 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #43588 from rdulmina/typeDesc-stmt

    Generate `new typedesc` instruction for record and tuple when type descriptor resolving
    rdulmina authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    e7ec6cc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    27b62a6 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #43597 from rdulmina/typeDesc-stmt

    Checkout Java21 branch in full build pipeline
    rdulmina authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    f1748e6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9fe124d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a75206d View commit details
    Browse the repository at this point in the history
  10. Merge pull request #43599 from rdulmina/typeDesc-stmt

    Checkout typeDesc-stmt branch in full build pipeline
    rdulmina authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    25c8c6c View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2c75b6c View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Merge pull request #43604 from rdulmina/typeDesc-stmt

    [typeDesc-stmt] Fix usage of incorrect branch in full build pipeline
    rdulmina authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0cb6c1a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f065eb5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    358d07e View commit details
    Browse the repository at this point in the history
  4. Fix branch checkout command

    rdulmina committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7e6125c View commit details
    Browse the repository at this point in the history
  5. Address review suggestions

    rdulmina committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f9da8b6 View commit details
    Browse the repository at this point in the history
  6. Set annotation for the referred type if it is record

    Previously we set the annotation for record type only. Now we set for both the type reference type and record type
    rdulmina committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e5f1afc View commit details
    Browse the repository at this point in the history
  7. Fix checkstyle issue

    rdulmina committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7535598 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Configuration menu
    Copy the full SHA
    38e2267 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    27bafe0 View commit details
    Browse the repository at this point in the history
  3. Fix import order

    rdulmina committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    2884daf View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Configuration menu
    Copy the full SHA
    fb628eb View commit details
    Browse the repository at this point in the history
  2. Revert "Fix set of failing test due to type mismatch"

    This reverts commit f1ebb95
    rdulmina committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    35555f3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dd0d8f5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    31c6b6b View commit details
    Browse the repository at this point in the history
  5. Merge remote-tracking branch 'upstream/master' into typeDesc-stmt

    # Conflicts:
    #	bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/MapValueImpl.java
    rdulmina committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    b189a55 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bc42da5 View commit details
    Browse the repository at this point in the history
  7. Revert "Use referred type when creating typedesc for maps"

    This reverts commit bc42da5.
    rdulmina committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    7e04bf7 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Configuration menu
    Copy the full SHA
    c0fa12d View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Refactor code

    rdulmina committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    103fc70 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6fedbfa View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Configuration menu
    Copy the full SHA
    ff7605e View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2024

  1. Configuration menu
    Copy the full SHA
    454355e View commit details
    Browse the repository at this point in the history
  2. Update comment

    rdulmina committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    77725a3 View commit details
    Browse the repository at this point in the history