-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Master] Generate new typedesc instruction for record and tuple when type descriptor resolving #43596
Open
rdulmina
wants to merge
99
commits into
master
Choose a base branch
from
typeDesc-stmt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+972
−666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ors" This reverts commit 962d8f9.
…onstructors"" This reverts commit d470345.
Add closures before the dependent node in the top-level node list in `ClosureGenerator.java`
Exclude field generation for typedesc when generating fields for user defined types since those fields will be generated when visiting global variables
Add typedesc statement before the var declaration in the init function body
MaryamZi
reviewed
Nov 19, 2024
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/TypeChecker.java
Outdated
Show resolved
Hide resolved
compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/BIRGen.java
Outdated
Show resolved
Hide resolved
compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/BIRGen.java
Outdated
Show resolved
Hide resolved
compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/BIRGen.java
Outdated
Show resolved
Hide resolved
} | ||
} | ||
|
||
// TODO: we need to remove typedesc creating completely from here and handle it in the Desugar phase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What scenario is this required for atm?
compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/BIRGen.java
Outdated
Show resolved
Hide resolved
rdulmina
force-pushed
the
typeDesc-stmt
branch
3 times, most recently
from
November 19, 2024 07:22
c7288dc
to
d70aefa
Compare
rdulmina
force-pushed
the
typeDesc-stmt
branch
from
November 19, 2024 07:39
d70aefa
to
7e6125c
Compare
Previously we set the annotation for record type only. Now we set for both the type reference type and record type
rdulmina
force-pushed
the
typeDesc-stmt
branch
from
November 19, 2024 14:28
a97ead4
to
e5f1afc
Compare
This reverts commit f1ebb95
rdulmina
force-pushed
the
typeDesc-stmt
branch
from
November 21, 2024 10:34
5551ed0
to
dd0d8f5
Compare
# Conflicts: # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/MapValueImpl.java
This reverts commit bc42da5.
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Team/CompilerFE
All issues related to Language implementation and Compiler, this exclude run times.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In this PR, I have generated a new 'typedesc' (type descriptor) only once for the tuple and record.
For example:
We have desugared the above program as follows:
We then use the generated 'typedesc' when creating a map value using that type.
Fixes #38844, #41946, #43311