Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-17146 Include note to remove migration znode #620

Open
wants to merge 2 commits into
base: asf-site
Choose a base branch
from
Open

KAFKA-17146 Include note to remove migration znode #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bb9f75
include step to remove zk migration znode
mumrah Aug 1, 2024
1012a4a
add second mention of rmr /migration
mumrah Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions 37/ops.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4098,7 +4098,10 @@ <h3>Reverting to ZooKeeper mode During the Migration</h3>
</li>
<li>
Using <code>zookeeper-shell.sh</code>, run <code>rmr /controller</code> so that one
of the brokers can become the new old-style controller.
of the brokers can become the new old-style controller. Additionally, run
<code>get /migration</code> followed by <code>rmr /migration</code> to clear the
migration state from ZooKeeper. This will allow you to re-attempt the migration
in the future. The data read from "/migration" can be useful for debugging.
</li>
<li>
On each broker, remove the <code>zookeeper.metadata.migration.enable</code>,
Expand Down Expand Up @@ -4132,7 +4135,10 @@ <h3>Reverting to ZooKeeper mode During the Migration</h3>
</li>
<li>
Using <code>zookeeper-shell.sh</code>, run <code>rmr /controller</code> so that one
of the brokers can become the new old-style controller.
of the brokers can become the new old-style controller. Additionally, run
<code>get /migration</code> followed by <code>rmr /migration</code> to clear the
migration state from ZooKeeper. This will allow you to re-attempt the migration
in the future. The data read from "/migration" can be useful for debugging.
</li>
<li>
On each broker, remove the <code>zookeeper.metadata.migration.enable</code>,
Expand Down
10 changes: 8 additions & 2 deletions 38/ops.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4105,7 +4105,10 @@ <h3>Reverting to ZooKeeper mode During the Migration</h3>
</li>
<li>
Using <code>zookeeper-shell.sh</code>, run <code>rmr /controller</code> so that one
of the brokers can become the new old-style controller.
of the brokers can become the new old-style controller. Additionally, run
<code>get /migration</code> followed by <code>rmr /migration</code> to clear the
migration state from ZooKeeper. This will allow you to re-attempt the migration
in the future. The data read from "/migration" can be useful for debugging.
Comment on lines +4108 to +4111
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update it in L4147 (Migrating brokers to KRaft row)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I don't notice this comment. apache/kafka#16770 is merged. I will sync the changes back to kafka repo if it needs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have commented the corresponding JIRA to understand in which state the user rollbacks the cluster to restart the migration because I tried this scenario more times without deleting the /migration znode and it worked fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @showuon, added the second mention. I wonder why we have this duplication? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why we have this duplication?

it seems we list all directions for reverting for each migration phase. That is a bit verbose, but they are useful. However, it is weird to use "table format" to display so much texts. Maybe we should to a bit refactor for it. Also, the same direction can have its hyperlink to be shared in different migration phase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I file jira for it (https://issues.apache.org/jira/browse/KAFKA-17271)

</li>
<li>
On each broker, remove the <code>zookeeper.metadata.migration.enable</code>,
Expand Down Expand Up @@ -4142,7 +4145,10 @@ <h3>Reverting to ZooKeeper mode During the Migration</h3>
</li>
<li>
Using <code>zookeeper-shell.sh</code>, run <code>rmr /controller</code> so that one
of the brokers can become the new old-style controller.
of the brokers can become the new old-style controller. Additionally, run
<code>get /migration</code> followed by <code>rmr /migration</code> to clear the
migration state from ZooKeeper. This will allow you to re-attempt the migration
in the future. The data read from "/migration" can be useful for debugging.
</li>
<li>
On each broker, remove the <code>zookeeper.metadata.migration.enable</code>,
Expand Down