Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing reference_material_id #323

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pkuiper-ultimaker
Copy link
Contributor

@pkuiper-ultimaker pkuiper-ultimaker commented Oct 23, 2024

PR from Jelle Spijker.

Curator gets its reference_material_id from the material definitions without an actual mapping.

See also: https://github.com/Ultimaker/autogenerate_print_profiles/pull/216 from which the materials were generated based on the 5.9 branch

Contribute to NP-474

Copy link
Member

@jellespijker jellespijker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jellespijker
Copy link
Member

@HellAholic feel free to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants