Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing reference_material_id #322

Closed
wants to merge 2 commits into from
Closed

Conversation

jellespijker
Copy link
Member

Curator gets its reference_material_id from the material definitions without an actual mapping.

See also: https://github.com/Ultimaker/autogenerate_print_profiles/pull/216 from which the materials were generated based on the 5.9 branch

Contribute to NP-474

@rburema
Copy link
Member

rburema commented Oct 23, 2024

I see two completely new materials as well. Is that correct?

@jellespijker
Copy link
Member Author

@pkuiper-ultimaker since these files have been generated with the script can you explain why they're here?

Copy link
Contributor

@pkuiper-ultimaker pkuiper-ultimaker Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need a reference_material_id for generic brand materials. We only support Ultimaker brand materials for method and sketch. The Generic materials are all excluded in teh machine definitions of these machines.
For other machines the material_reference_id has no meaning at all. Best not to put materials reference ids for the generic materials in the all_materials.csv.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just syncing them with how they're currently used in Cura, DF, Lauren based on the uuid.

When I'm back on Wednesday I will create aan Look up table for the Mirage on look-up-tables that we have.

Let's leave these PR's open for now. We don't have a rush to get these in before Wednesday

Copy link
Contributor

@pkuiper-ultimaker pkuiper-ultimaker Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only removed ASA and Nylon-CF for now, because there are already Ultimaker materials linked to them. The PC. BVOH, CPE, TPU and HIPS have no Ultimaker material mapped to them, so we can use the Generic materials.

@pkuiper-ultimaker
Copy link
Contributor

Rejected in favor of #323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants