Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmotionTech materials updated #227

Closed
wants to merge 10 commits into from
Closed

EmotionTech materials updated #227

wants to merge 10 commits into from

Conversation

NicolasBOYARD
Copy link
Contributor

PA6CF and PA6GF added to eMotionTech materials
PA10XX removed from eMotionTech materials
COPA temperature updated
In each resulting material .xml.fdm_material file, IDEX420 Printers machine added

@NicolasBOYARD
eMotionTech materials update from 4.11 to 5.1
0755838 
eMotionTech materials files updated to be used by DUAL600 and IDEX420 machines
@NicolasBOYARD
eMotionTech materials update
e939ff0 
COPA temps updated
nylon 1030, 1030CF and 1070 deleted
PA6CF and PA6GF added
@NicolasBOYARD
High Temp removed on IDEX420
bd017e9 
Comment every paragraph in emotiontech material files which concern declaration of HT0.4 or HT0.6 as variant
@NicolasBOYARD
eMotionTech PEKK variant affectation corrected
240c6b6
@NicolasBOYARD
eMotionTech PEKK material file indented
506b63c
@nallath
Copy link
Member

nallath commented Sep 15, 2022

Removing profiles will cause issues without an upgrade script in Cura. If project files still use them, they will become corrupted. As such, please create an accompanying PR that solves that (or simply don't remove the material).

Is there a specific reason that you've removed these profiles?

@NicolasBOYARD
eMotionTech material files rewrite of machines and variant applicables
0ce47a4
@NicolasBOYARD
eMotionTech conformity for PR #13290
ce91012 
eMotioTech materials definition files are applied to DUAL600 (overrides of default parameters, specific to DUAL600 prinheads) and to IDEX420 and submachines (overrides of default parameters, specific to IDEX420 prinheads)
@NicolasBOYARD
Copy link
Contributor Author

Hello nallath, sorry, I didn't answer this ask. Yes, we removed these 3 materials because they were added in expecting of sells but we never sold it. So, instead of polluting Cura files with useless files, we prefer to remove them.

@jellespijker jellespijker added the PR: Community Contribution 👑 Community Contribution PR's label Nov 30, 2022
@Joeydelarago Joeydelarago self-assigned this Jan 6, 2023
@Joeydelarago
Copy link
Contributor

Joeydelarago commented Jan 11, 2023 •
edited
Loading

Hey @NicolasBOYARD, as nallath mentioned we can't remove materials without an upgrade script (unimplemented). So I suggest you add the files back and put a xml comment at the top of the file saying they are deprecated.

Please hit the "Ready for Review" button when you have made these changes. Thanks!

@Joeydelarago Joeydelarago marked this pull request as draft January 11, 2023 12:34
@saumyaj3 saumyaj3 mentioned this pull request Sep 12, 2023
Merged
10 tasks
@NicolasBOYARD NicolasBOYARD marked this pull request as ready for review September 12, 2023 12:35
@saumyaj3
Copy link
Contributor

Hey @NicolasBOYARD!
As @nallath and @Joeydelarago mentioned above, The Cura upgrade script won't work if we delete the materials. Can you please put them back so that the printer definitions PR: Ultimaker/Cura#15101 could be updated? @Joeydelarago suggestion could be helpful.

@saumyaj3 saumyaj3 marked this pull request as draft September 15, 2023 10:11
@NicolasBOYARD
Copy link
Contributor Author

Hi @saumyaj3 , Sorry, I re-read every comments on this conversation : files of the 3 deprecated materials are back with "deprecated" in the name and set to "non compatible" with the printers.
Linter has been successfully checked

@saumyaj3
Copy link
Contributor

Hi @saumyaj3 , Sorry, I re-read every comments on this conversation : files of the 3 deprecated materials are back with "deprecated" in the name and set to "non compatible" with the printers. Linter has been successfully checked

Hey! I see another PR open #249 with the said changes. I'll close this one.

@saumyaj3 saumyaj3 closed this Sep 15, 2023
NicolasBOYARD added a commit to eMotion-Tech/fdm_materials that referenced this pull request Oct 5, 2023
@NicolasBOYARD
correction of EmotionTech materials updated Ultimaker#227
1d9f026 
material filess re-added :
emotiontech_nylon_1030.xml.fdm_material
emotiontech_nylon_1030cf.xml.fdm_material
emotiontech_nylon_1070.xml.fdm_material

every material is renamed with suffix "deprecated" and set "non compatible" to eMotionTech machines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Joeydelarago Joeydelarago

Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NicolasBOYARD @nallath @Joeydelarago @saumyaj3 @jellespijker