Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update our machine DUAL600 & IDEX420 #15101

Merged
merged 21 commits into from
Sep 15, 2023
Merged

Update our machine DUAL600 & IDEX420 #15101

merged 21 commits into from
Sep 15, 2023

Conversation

eMotion-Tech
Copy link
Contributor

@eMotion-Tech eMotion-Tech commented Mar 31, 2023 •
edited
Loading

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Printer definition file(s)
  • Translations

How Has This Been Tested?

  • Test A
  • Test B

Test Configuration:

  • Operating System:

Checklist:

@NicolasBOYARD
eMotionTech - Strateo IDEX420 added to Cura
f6e6b8c 
Files added to :
- definitions
- extruders
- quality
- variant
setting_version has benn updated to "21"
XML file "product_to_id.json" has been updated because "STRATEO3D" is noww a brand of 2 machines : DUAL600 and IDEX420
IDEX420 is a "IDEX" machine, so we created 3 definition files : 1 main file "strateo3d_IDEX420" and 2 inherited files "strateo3d_IDEX420_duplicate" and "strateo3d_IDEX420_mirror"
materials PA6CF and PA6GF added to both machines in quality folders
@NicolasBOYARD
eMotionTech IDEX420 Mirror definition update
0386976 
In file definition of Strateo IDEX420 mirror, previously, Start Gcode had in comment "select the duplicate tool".
It is now corrected by "select the mirror tool"
@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Mar 31, 2023
@MariMakes MariMakes added the PR: Printer Definitions 🏭 A PR that introduces or changes settings and printer definitions label Apr 5, 2023
@eMotion-Tech
Copy link
Contributor Author

Hi, I can't pass the unit-test and I don't know why ?
I have only change définition file of my printer can you help me ?
My pr it's ok to pass or not ?
thank you very much

@eMotion-Tech
Copy link
Contributor Author

I think we have found our problems.
Waiting from you now.

@eMotion-Tech eMotion-Tech mentioned this pull request Apr 25, 2023
Draft
@NicolasBOYARD
eMotionTech
68250ec 
Remove T{initial_extruder_nr} from DUAL600 and IDEX420 start gcode (it was mandatory in Cura 4.xx but created a minor bug in Cura 5.xx)
@NicolasBOYARD
Merge branch 'main' of https://github.com/eMotion-Tech/Cura
2ab02f6
github-actions[bot]
github-actions bot previously requested changes May 4, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

resources/definitions/strateo3d.def.json Outdated Show resolved Hide resolved
@eMotion-Tech
Copy link
Contributor Author

We think the clang-tidy is fix

NicolasBOYARD and others added 4 commits May 24, 2023 10:37
@NicolasBOYARD
eMotionTech
4f4e97e 
Cooling removed in ABS material quality files
ASA-X copied from ABS-X material quality files
Speeds caped in IDEX420 machine definition file
@eMotion-Tech
Merge branch 'Ultimaker:main' into main
5bac3d1
@NicolasBOYARD
Merge branch 'main' of https://github.com/eMotion-Tech/Cura
9869832
@eMotion-Tech
Merge branch 'Ultimaker:main' into main
49737bc
@qleboeuf
Copy link

qleboeuf commented Jul 6, 2023

No help about this ?

@qleboeuf
Copy link

qleboeuf commented Sep 6, 2023

hi @MariMakes we don't have update from you since a while ? There is something that we can do ?

@rburema rburema removed their assignment Sep 12, 2023
@saumyaj3
Copy link
Contributor

saumyaj3 commented Sep 12, 2023 •
edited
Loading

Hi!
Thankyou for your contribution. I was reviewing the PR and found material "emotiontech_pa6cf" and ""emotiontech_pa6gf" not present in fdm_materials (https://github.com/Ultimaker/fdm_materials). Can you also add it there? Also, if you have created a PR there, please tag it here.

@saumyaj3 saumyaj3 closed this Sep 12, 2023
@saumyaj3 saumyaj3 reopened this Sep 12, 2023
@saumyaj3
Copy link
Contributor

I see PR Ultimaker/fdm_materials#227 which is not updated. Is it possible to fix the comments in this one?

@QuentinADM
Copy link

Hi @saumyaj3 We have add file and fix PR on Ultimaker/fdm_materials#227 and we have click on button "Ready for review" like asking. It's ok for you ?

@saumyaj3
Copy link
Contributor

Hi @saumyaj3 We have add file and fix PR on Ultimaker/fdm_materials#227 and we have click on button "Ready for review" like asking. It's ok for you ?

Hi @QuentinADM,
I see the comments in the PR :Ultimaker/fdm_materials#227 are not fixed yet. Can you make sure to undo deleted file and update PR?

@saumyaj3 saumyaj3 mentioned this pull request Sep 15, 2023
Closed
@saumyaj3
Copy link
Contributor

New Pr for fdm materials: Ultimaker/fdm_materials#249

@saumyaj3 saumyaj3 merged commit 3976aa6 into Ultimaker:main Sep 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saumyaj3 saumyaj3 saumyaj3 approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@saumyaj3 saumyaj3

Labels
PR: Community Contribution 👑 Community Contribution PR's PR: Printer Definitions 🏭 A PR that introduces or changes settings and printer definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@eMotion-Tech @qleboeuf @saumyaj3 @QuentinADM @MariMakes @rburema @NicolasBOYARD