Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.hikari: fix build #355886

Merged
merged 2 commits into from
Nov 18, 2024
Merged

python312Packages.hikari: fix build #355886

merged 2 commits into from
Nov 18, 2024

Conversation

itepastra
Copy link
Member

  • python3Packages.hikari: format using nixfmt
  • python3Packages.hikari: fix build Remove the asyncio_default_fixture_loop_scope from pyproject.toml

ZHF: #352882

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

tomodachi94
tomodachi94 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, though I'm hesitant to make this the long-term fix.

Further investigation at a later date would be appreciated (though I'm fine with this being merged as-is): Do we know why this occurs?

@itepastra
Copy link
Member Author

I think I may be able to make the change smaller, but I have to go sleep and will look at this tomorrow if I have time

@itepastra itepastra changed the title python3Packages.hikari: fix build python312Packages.hikari: fix build Nov 15, 2024
@tomodachi94
Copy link
Member

tomodachi94 commented Nov 15, 2024 •
edited
Loading

This occurs because our pytest-asyncio is outdated. asyncio_default_fixture_loop_scope was introduced in 0.24, but we are on 0.23.6.

I think the proper fix is to update that package instead. Thoughts?

@itepastra
Copy link
Member Author

itepastra commented Nov 15, 2024 •
edited
Loading

Seems like that pr was already created a while ago #336640. but it seems to have other issues so isn't merged yet. Until it is this would resolve the issue with hikari

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 15, 2024
@tomodachi94
Copy link
Member

Considering the above PR has stalled, I'd say this is okay to merge, provided we revert it once the update is applied.

@itepastra
Copy link
Member Author

agreed, should I add a comment that it should be removed after the pr is merged?

@tomodachi94
Copy link
Member

tomodachi94 commented Nov 18, 2024 •
edited
Loading

Yes, that would be ideal ❤️ 🚀

@itepastra
python3Packages.hikari: fix build
f278e7f 
Remove the `asyncio_default_fixture_loop_scope` from pyproject.toml
tomodachi94
tomodachi94 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks ❤️

@tomodachi94 tomodachi94 mentioned this pull request Nov 18, 2024
Closed
13 tasks
@tomodachi94 tomodachi94 merged commit 6e1b17d into NixOS:master Nov 18, 2024
10 of 11 checks passed
@tomodachi94 tomodachi94 mentioned this pull request Nov 18, 2024
Closed
@tomodachi94 tomodachi94 added the backport release-24.11 Backport PR automatically label Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 18, 2024
Merged
1 task
@itepastra itepastra deleted the hikari branch November 18, 2024 19:43
@itepastra itepastra restored the hikari branch November 18, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomodachi94 tomodachi94 tomodachi94 approved these changes

@Sigmanificient Sigmanificient Sigmanificient approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itepastra @tomodachi94 @Sigmanificient @wegank