Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.hikari: remove asyncio_default_fixture_loop_scope #357037

Closed
wants to merge 1 commit into from

Conversation

Shawn8901
Copy link
Contributor

@Shawn8901 Shawn8901 commented Nov 18, 2024

Having this as a workaround since some times on my fork.
It was bumped in nixos with 828039a to a commit that had that option and never built since then

# pytest.PytestConfigWarning: Unknown config option: asyncio_default_fixture_loop_scope
applies basically the same "workaround".

fixes #353691

see https://hydra.nixos.org/build/278318782

ZHF: #352882

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Shawn8901 Shawn8901 added backport release-24.11 Backport PR automatically 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign labels Nov 18, 2024
@tomodachi94
Copy link
Member

This might be a duplicate of #355886, but I'm not sure.

@Shawn8901 Shawn8901 closed this Nov 18, 2024
@Shawn8901 Shawn8901 deleted the unbreak-hikari branch November 18, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: python backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: python3Packages.hikari
2 participants