Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poppler: remove poppler_gi variant #223577

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkgs/applications/editors/setzer/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
, gobject-introspection
, gtksourceview4
, gspell
, poppler_gi
, poppler
, webkitgtk
, librsvg
}:
Expand Down Expand Up @@ -43,7 +43,7 @@ python3.pkgs.buildPythonApplication rec {
buildInputs = [
gtksourceview4
gspell
poppler_gi
poppler
webkitgtk
librsvg
];
Expand Down
4 changes: 2 additions & 2 deletions pkgs/applications/misc/metadata-cleaner/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
, meson
, ninja
, pkg-config
, poppler_gi
, poppler
, wrapGAppsHook4
}:

Expand Down Expand Up @@ -47,7 +47,7 @@ python3.pkgs.buildPythonApplication rec {
gtk4
libadwaita
librsvg
poppler_gi
poppler
];

propagatedBuildInputs = with python3.pkgs; [
Expand Down
2 changes: 1 addition & 1 deletion pkgs/applications/misc/pdf-quench/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ python3.pkgs.buildPythonApplication {
buildInputs = with pkgs; [
gtk3
goocanvas2
poppler_gi
poppler
];
propagatedBuildInputs = with python3.pkgs; [ pygobject3 pypdf2 ];

Expand Down
4 changes: 2 additions & 2 deletions pkgs/applications/misc/pdfarranger/default.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{ fetchFromGitHub, lib
, wrapGAppsHook, intltool
, python3Packages, gtk3, poppler_gi
, python3Packages, gtk3, poppler
}:

python3Packages.buildPythonApplication rec {
Expand All @@ -21,7 +21,7 @@ python3Packages.buildPythonApplication rec {
]);

buildInputs = [
gtk3 poppler_gi
gtk3 poppler
];

propagatedBuildInputs = with python3Packages; [
Expand Down
2 changes: 1 addition & 1 deletion pkgs/applications/office/paperwork/openpaperwork-gtk.nix
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ buildPythonPackage rec {
propagatedBuildInputs = [
pillow
pygobject3
pkgs.poppler_gi
pkgs.poppler
pkgs.gtk3
pkgs.libhandy
distro
Expand Down
4 changes: 2 additions & 2 deletions pkgs/applications/office/paperwork/paperwork-backend.nix
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
, openpaperwork-gtk
, psutil
, gtk3
, poppler_gi
, poppler
, gettext
, which
, shared-mime-info
Expand Down Expand Up @@ -64,7 +64,7 @@ buildPythonPackage rec {
pyocr
pypillowfight
levenshtein
poppler_gi
poppler
scikit-learn
termcolor
whoosh
Expand Down
4 changes: 2 additions & 2 deletions pkgs/applications/office/pympress/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
, gtk3
, gobject-introspection
, libcanberra-gtk3
, poppler_gi
, poppler
, withGstreamer ? stdenv.isLinux
, withVLC ? stdenv.isLinux
}:
Expand All @@ -26,7 +26,7 @@ python3Packages.buildPythonApplication rec {

buildInputs = [
gtk3
poppler_gi
poppler
] ++ lib.optional withGstreamer libcanberra-gtk3;

propagatedBuildInputs = with python3Packages; [
Expand Down
12 changes: 6 additions & 6 deletions pkgs/development/haskell-modules/hackage-packages.nix

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 7 additions & 2 deletions pkgs/development/libraries/poppler/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@
, scribus
, texlive
, zlib
, gobject-introspection
, buildPackages
, withData ? true, poppler_data
, qt5Support ? false, qt6Support ? false, qtbase ? null
, introspectionSupport ? false, gobject-introspection ? null
, withIntrospection ? stdenv.hostPlatform.emulatorAvailable buildPackages && suffix == "glib"
, utils ? false, nss ? null
, minimal ? false
, suffix ? "glib"
Expand Down Expand Up @@ -61,6 +63,8 @@ stdenv.mkDerivation (finalAttrs: rec {
ninja
pkg-config
python3
] ++ lib.optionals withIntrospection [
gobject-introspection
];

buildInputs = [
Expand All @@ -86,7 +90,8 @@ stdenv.mkDerivation (finalAttrs: rec {
nss
] ++ lib.optionals (qt5Support || qt6Support) [
qtbase
] ++ lib.optionals introspectionSupport [
] ++ lib.optionals withIntrospection [
# TODO: REMOVE
gobject-introspection
];

Copy link
Member

@jtojnar jtojnar Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And change to only build GLIB in cmakeFlags when suffix is glib here.

Expand Down
4 changes: 2 additions & 2 deletions pkgs/development/python-modules/mat2/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
, gdk-pixbuf
, gobject-introspection
, librsvg
, poppler_gi
, poppler
, mutagen
, pygobject3
, pycairo
Expand Down Expand Up @@ -72,7 +72,7 @@ buildPythonPackage rec {
buildInputs = [
gdk-pixbuf
librsvg
poppler_gi
poppler
];

propagatedBuildInputs = [
Expand Down
1 change: 1 addition & 0 deletions pkgs/top-level/aliases.nix
Original file line number Diff line number Diff line change
Expand Up @@ -1263,6 +1263,7 @@ mapAliases ({
pond = throw "pond has been dropped due to the lack of maintanence from upstream since 2016"; # Added 2022-06-02
poppler_qt5 = throw "'poppler_qt5' has been renamed to/replaced by 'libsForQt5.poppler'"; # Converted to throw 2022-02-22
powerdns = pdns; # Added 2022-03-28
poppler_gi = poppler; # Added 2023-03-27
portaudio2014 = throw "'portaudio2014' has been removed"; # Added 2022-05-10

# postgresql
Expand Down
4 changes: 0 additions & 4 deletions pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -23089,10 +23089,6 @@ with pkgs;

poppler = callPackage ../development/libraries/poppler { lcms = lcms2; };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should name this poppler-glib then.


poppler_gi = lowPrio (poppler.override {
introspectionSupport = true;
});

poppler_min = poppler.override { # TODO: maybe reduce even more
# this is currently only used by texlive.bin.
minimal = true;
Expand Down
2 changes: 1 addition & 1 deletion pkgs/top-level/pkg-config/pkg-config-data.json
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,7 @@
},
"poppler-glib": {
"attrPath": [
"poppler_gi"
"poppler"
]
},
"python": {
Expand Down