poppler: remove poppler_gi variant #223577
Open
+29
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -114019,7 +114019,7 @@ self: { | |||
| "gi-poppler" = callPackage | |||
| ({ mkDerivation, base, bytestring, Cabal, containers, gi-cairo | |||
| , gi-gio, gi-glib, gi-gobject, haskell-gi, haskell-gi-base | |||
| , haskell-gi-overloading, poppler_gi, text, transformers | |||
| , haskell-gi-overloading, poppler, text, transformers | |||
There was a problem hiding this comment.
@NixOS/haskell does this need some update in the tooling?
There was a problem hiding this comment.
ofborg
bot
requested review from
dotlambda,
jtojnar,
tbenst,
flokli,
symphorien,
aszlig and
ttuegel
|
Poppler actually consists of three (or four) different libraries: the native C++ API, GObject-based API and Qt-based API. |
there's no need to have a separate attr for a gi poppler
Artturin
force-pushed
the
removepopplergi
branch
from
8df912f
to
4fbffe0
Compare
Artturin
added a commit
to Artturin/cabal2nix
that referenced
this pull request
Apr 3, 2023
|
Added pr to cabal2nix NixOS/cabal2nix#599 |
jtojnar
reviewed
Apr 3, 2023
| @@ -23089,10 +23089,6 @@ with pkgs; | |||
|
|
|||
| poppler = callPackage ../development/libraries/poppler { lcms = lcms2; }; | |||
There was a problem hiding this comment.
Maybe we should name this poppler-glib then.
jtojnar
reviewed
Apr 3, 2023
| @@ -86,7 +90,8 @@ stdenv.mkDerivation (finalAttrs: rec { | |||
| nss | |||
| ] ++ lib.optionals (qt5Support || qt6Support) [ | |||
| qtbase | |||
| ] ++ lib.optionals introspectionSupport [ | |||
| ] ++ lib.optionals withIntrospection [ | |||
| # TODO: REMOVE | |||
| gobject-introspection | |||
| ]; | |||
|
|
|||
There was a problem hiding this comment.
And change to only build GLIB in cmakeFlags when suffix is glib here.
ofborg
bot
added
10.rebuild-linux: 101-500
and removed
10.rebuild-linux: 501+
10.rebuild-linux: 501-1000
labels
wegank
added
the
2.status: stale
wegank
added
the
2.status: merge conflict
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there's no need to have a separate attr for a gi poppler
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)