Update lift-shift-to-containers.md #1998
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update for newer .NET
|
Learn Build status updates of commit b24f579: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
richlander
reviewed
Nov 23, 2024
| @@ -257,7 +257,7 @@ When validating if the application to be containerized works on Windows containe | |||
| |---|---|---|---| | |||
| |.NET Framework versions 2.X and 3.X|.NET Framework 4.x|.NET Framework 3.5|Windows Server Core| | |||
| |.NET Framework 4.x versions|.NET Framework 4.x|Build your .NET Framework container image with Server or Windows images|Windows Server Core| | |||
| |.NET 6 or 7|.NET 6 or 7 respectively|Build your .NET container image with Windows or Server base images|Windows Nano Server or Server Core| | |||
| |.NET 6 or later|Matching .NET container image, for example .NET 9 for .NET 9|Build your .NET container image with Windows or Server base images|Windows Nano Server or Server Core| | |||
There was a problem hiding this comment.
for example .NET 9 for .NET 9
That phrasing doesn't pop for me. As a user, I'm not quite sure how I'd apply ".NET 9" to containers. Perhaps "9.0" is closer?
I'm not sure this whole table makes much sense. For example, recommending .NET Framework 4.x images for a 2.x/3.x app won't work. That will launch FOD on Windows client, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for newer .NET. @richlander @MichaelSimons is this right?