Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert some typedefs to using #657

Merged
merged 1 commit into from
Feb 18, 2018
Merged

Conversation

jolting
Copy link
Member

@jolting jolting commented Feb 18, 2018

I didn't get all typedefs, but it's a start.


I acknowledge to have:

(Notify: @MRPT/owners )

@jlblancoc
Copy link
Member

wow, great! I manually changed a few of them, but clearly not enough...

cc: #66

@jlblancoc jlblancoc merged commit deca624 into MRPT:master Feb 18, 2018
@jlblancoc
Copy link
Member

Also, many complex typedefs and cumbersome for() loops could be converted to auto and ranges. I already changed a few as I stepped into them, but nothing systematic yet. Also, in some cases it might be informative to leave the real types instead of auto (mainly, in heavily template-based code where it's easy to lose grip).

@jolting
Copy link
Member Author

jolting commented Feb 18, 2018

Most of these were done using a sed replacement.

4935 remaining typedefs, but that includes some of the otherlibs, which I avoided.
22.5% of remaining typedefs are in exprtk.hpp

Also my sed replacement trick missed all the multi-line typedef and the function typedefs.

@jlblancoc
Copy link
Member

Also my sed replacement trick missed all the multi-line typedef and the function typedefs.

I'm annoyed by how hard it seems to be to run regex replacements when dealing with multilines... (sigh)
After much wasted time trying it with command line tools and with Atom, the best similar thing I found (though, not 100% regex compatible) is Notepad++... a Windows GUI tool :-( I feel like I must be missing "The Easy Way" (!?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants