Update our OTel dependencies, and move config into GMP module #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #709 +/- ##
==========================================
+ Coverage 69.56% 69.60% +0.04%
==========================================
Files 36 37 +1
Lines 4711 4728 +17
==========================================
+ Hits 3277 3291 +14
- Misses 1286 1289 +3
Partials 148 148
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aabmass
approved these changes
Aug 21, 2023
codeboten
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Aug 29, 2023
Update googlecloud dependency from v0.42.0 to v0.43.0. See the full set of changes here: https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/releases/tag/v0.43.0 I refactored the API surface of the googlemanagedprometheus package to minimize future breaking changes in GoogleCloudPlatform/opentelemetry-operations-go#709. This created a Config struct in that package with configuration options for functions in the package. It is backwards-compatible with the configuration currently in the googlemanagedprometheus exporter, but adds a new option `add_metric_suffixes`. This also removes the deprecated BuildPromCompliantName now that the googlemanagedprometheus library has migrated to the new function. **Testing:** Expanded config unit test to cover all fields. **Documentation:** Updated the README with new `add_metric_suffixes` configuration. This configuration matches the configuration used by the prometheus remote write and prometheus exporters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to switch from prometheus.BuildPromCompliantName to prometheus.BuildCompliantName, which takes an argument for enabling unit suffixes. We would like to allow users to disable unit suffixes, as the (upstream) feature gate will not apply to unit suffixes anymore.
I decided to simplify our API surface in the GMP module to reduce the number of breaking changes we will need to make in the future. To do this, I moved configuration related to naming, resource, and extra metrics into a config struct in this module. This will not result in any breaking changes upstream, since it copies existing configuration from the GMP exporter for target and scope info.
This also simplifies up the ExtraMetrics function, since we don't need to have it return anything.