Update googlecloud dependency to v0.43.1 #26071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/configschema
github-actions
bot
requested review from
aabmass,
damemi,
pmcollins,
psx95 and
punya
dashpole
force-pushed
the
update_googlecloud_version
branch
2 times, most recently
from
697cc35
to
c4d780d
Compare
|
Looks like this is blocked on updating to go 1.21. I'll convert to a draft for now. Edit: reverted back to 1.20 in a patch release. Should be good to go now. |
dashpole
force-pushed
the
update_googlecloud_version
branch
from
c4d780d
to
0694863
Compare
dashpole
force-pushed
the
update_googlecloud_version
branch
from
0694863
to
25d95e0
Compare
codeboten
approved these changes
Aug 29, 2023
dashpole
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update googlecloud dependency from v0.42.0 to v0.43.1. See the full set of changes here: https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/releases/tag/v0.43.0
I refactored the API surface of the googlemanagedprometheus package to minimize future breaking changes in GoogleCloudPlatform/opentelemetry-operations-go#709. This created a Config struct in that package with configuration options for functions in the package. It is backwards-compatible with the configuration currently in the googlemanagedprometheus exporter, but adds a new option
add_metric_suffixes.This also removes the deprecated BuildPromCompliantName now that the googlemanagedprometheus library has migrated to the new function.
Testing:
Expanded config unit test to cover all fields.
Documentation:
Updated the README with new
add_metric_suffixesconfiguration. This configuration matches the configuration used by the prometheus remote write and prometheus exporters.