Tools hive: LSF to Slurm migration #842
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azangru
changed the title
azangru
force-pushed
the
migrate-to-slurm
branch
from
8a8ad10
to
bd9e058
Compare
azangru
force-pushed
the
migrate-to-slurm
branch
from
bd9e058
to
1570bd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR are part of switching
ensembl-hivefrom version 2.2 to version 2.7, and of migration from LSF to Slurm. They include:beekeeper_manager.plto stop it from passing arbitrary command-line options tobeekeeper.pl(beekeeper.pl in ensembl-hive, which is the script that is eventually called, no longer allows options outside of the ones that it expects).beekeeper.plto fix a problem when it would call itself. You will notice that the old version ofbeekeeper.plhas adocommand, with which it callsbeekeeper.plinensembl-hive. For some reason that remains a mystery, after we switched ensembl-hive to version 2.7, ourbeekeeper.pl(i.e. the one in the public-plugins repo) started calling itself at thedoline instead of callingbeekeeper.plinensembl-hive. I have updated the file to useforkinstead ofdo.ToolsPipeConfig.pmand its subclasses to update the definition of jobs for SLURM