Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PERL 5.26 to build #168

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added PERL 5.26 to build #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8068baf
Added PERL 5.26 to build
marcoooo Apr 25, 2022
3e8d161
Tests updates
marcoooo Sep 30, 2022
f383783
update Mart Service to enforce encoding to utf8
marcoooo Oct 18, 2022
062281f
Change encoding when opening test file
marcoooo Oct 18, 2022
f32101b
Added trace
marcoooo Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ language: "perl"

perl:
- "5.14"

- '5.26'
env:
- COVERALLS=true DB=mysql

Expand Down
4 changes: 3 additions & 1 deletion modules/Bio/EnsEMBL/BioMart/MartService.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ sub get_filters {
mart => $dataset->mart()->name(),
virtualSchema => $dataset->mart()->virtual_schema(),
dataset => $dataset->name()});

print Dumper("test response", $response);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debug printouts should be removed.

open my $fh, '<', \$response or throw "Could not break ";
while (<$fh>) {
chomp;
Expand All @@ -160,6 +160,7 @@ sub get_filters {
my ($name, $display_name, $opt_str, $des, $page, $type, $operator, $table, $column) = split('\t', $_);
$opt_str ||= '';
$opt_str =~ s/\[(.*)\]/$1/;
print Dumper("opts ", $opt_str);
my @options = split(',', $opt_str);
if (defined $name) {
push @$filters,
Expand All @@ -176,6 +177,7 @@ sub get_filters {
-DATASET => $dataset);
}
}
print Dumper("filters", $filters);
return $filters;
} ## end sub get_filters

Expand Down
2 changes: 1 addition & 1 deletion modules/t/21-query-val.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,4 @@ my $data =
$srv->do_query( $mart, $dataset, [ $attribute, $attribute2 ], [{filter=>$filter, value=>'I'}] );
ok( defined $data, "Data found found" );

done_testing;
done_testing();