Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mlx Model (loglikelihood & generate_until) #1902

Open
wants to merge 72 commits into
base: main
Choose a base branch
from
Open

mlx Model (loglikelihood & generate_until) #1902

wants to merge 72 commits into from

Commits on May 20, 2024

  1. Initial implementation (no caching)

    @chimezie
    chimezie committed May 20, 2024
    Configuration menu
    Copy the full SHA
    6121d1b View commit details
    Browse the repository at this point in the history

  2. Fix model registration

    @chimezie
    chimezie committed May 20, 2024
    Configuration menu
    Copy the full SHA
    8319638 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Merge branch 'EleutherAI:main' into main

    @chimezie
    chimezie authored May 29, 2024
    Configuration menu
    Copy the full SHA
    75bc3f9 View commit details
    Browse the repository at this point in the history

  2. Self-standing loglikelihood implementation.

    @chimezie
    chimezie committed May 29, 2024
    Configuration menu
    Copy the full SHA
    01d80ca View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main'

    @chimezie
    chimezie committed May 29, 2024
    Configuration menu
    Copy the full SHA
    87979f0 View commit details
    Browse the repository at this point in the history

  4. pre-commit ruff issues

    @chimezie
    chimezie committed May 29, 2024
    Configuration menu
    Copy the full SHA
    bcfea6c View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored May 31, 2024
    Configuration menu
    Copy the full SHA
    08a0593 View commit details
    Browse the repository at this point in the history

  2. Various fixes

    @chimezie
    chimezie committed May 31, 2024
    Configuration menu
    Copy the full SHA
    9d50820 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. Typo

    @chimezie
    chimezie committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    9b575f7 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Jun 11, 2024
    Configuration menu
    Copy the full SHA
    71b2483 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    80623e4 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Merge remote-tracking branch 'upstream/main' into mlx

    @chimezie
    chimezie committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    f496a47 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Fix handling of final remainder batch

    @chimezie
    chimezie committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    1214693 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    e1d1d71 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    363024a View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    eba4fb2 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    24f1665 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ab89e53 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e4376d2 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7a1b419 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. Formatting fixes

    @chimezie
    chimezie committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    9c78e9f View commit details
    Browse the repository at this point in the history

  2. Added installation dependencies and checks for existence of mlx & mlx… 

    …_lm libraries
    @chimezie
    chimezie committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    423d2d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    00145ef View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ec8e7d1 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. Align with --apply_chat_template and add ensure_bos_token to model args

    @chimezie
    chimezie committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    786e067 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    c6d104f View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    da606ed View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    00e15a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    274391f View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    580e7d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    ff944e5 View commit details
    Browse the repository at this point in the history

  2. Don't truncate Q completion tokens as you would in training (more mem… 

    …ory use)
    @chimezie
    chimezie committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    e07e9a2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    41f050a View commit details
    Browse the repository at this point in the history

  4. Use HF implementation of apply chat template option

    @chimezie
    chimezie committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    131f424 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/mlx' into mlx

    @chimezie
    chimezie committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    0e426d0 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Update warning to indicate truncation is not happening

    @chimezie
    chimezie committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    d382107 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Provide until value

    @chimezie
    chimezie committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    07b5b8d View commit details
    Browse the repository at this point in the history

  2. Typo

    @chimezie
    chimezie committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    d93d945 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    e3863d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    d1df3a8 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    4a12ebe View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a868300 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    d0f0a8b View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. Merge branch 'main' into mlx 

    # Conflicts:
#	pyproject.toml
    @chimezie
    chimezie committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    2b412da View commit details
    Browse the repository at this point in the history

  2. Refactor MLX model loading and token handling 

    Simplify by removing unnecessary imports and the unused chat templating method. Adjust tokens and batch handling to properly manage sequence lengths and masking using latest, related mlx_lm bits (ml-explore/mlx-examples#825).
    @chimezie
    chimezie committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    038499b View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3f89dc7 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    6ab6bc8 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    e2d9ae7 View commit details
    Browse the repository at this point in the history

  2. Re-use HF for abstract methods

    @chimezie
    chimezie committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    907a06f View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/mlx' into mlx

    @chimezie
    chimezie committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    4b6c971 View commit details
    Browse the repository at this point in the history

  4. Fix collection of context/continuation, etc.

    @chimezie
    chimezie committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    d11aa55 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Various fixes 

    Fix batch processing to handle remainders and extraction of target conditional log probs.
    @chimezie
    chimezie committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    7ce767f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    7eed0f9 View commit details
    Browse the repository at this point in the history

  3. Revert to non-chat-templated tokens (per HF impl)

    @chimezie
    chimezie committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    d253bb1 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/mlx' into mlx

    @chimezie
    chimezie committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    c0e3366 View commit details
    Browse the repository at this point in the history

  5. Minor fix

    @chimezie
    chimezie committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    7a24829 View commit details
    Browse the repository at this point in the history

  6. Minor fix

    @chimezie
    chimezie committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    676dff9 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Fix calculation of 'context' lengths

    @chimezie
    chimezie committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    cc48c10 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. Incorporated PR comments (mainly moving to _loglikelihood_tokens) 

    However, getting jinja2 Exception ("Failed to apply chat template. removing the system role in chat history.") when trying (will add test cases once it run)
    @chimezie
    chimezie committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    d2e4222 View commit details
    Browse the repository at this point in the history

  2. Removed addition of EOS token

    @chimezie
    chimezie committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    3922864 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    5bdf50c View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. fixup

    @baberabb
    baberabb committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    f478fbc View commit details
    Browse the repository at this point in the history

  2. nit

    @baberabb
    baberabb committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    9df463f View commit details
    Browse the repository at this point in the history

  3. add typehints

    @baberabb
    baberabb committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    7f4aab5 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Nov 28, 2024
    Configuration menu
    Copy the full SHA
    d770703 View commit details
    Browse the repository at this point in the history

  2. Attempt to better mimic HF model loglikelihood_tokens impl of one-tok… 

    …en continuation caching, but getting a Key Error in re_ord.get_cache(..)
    @chimezie
    chimezie committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    9e2d8c9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Nov 28, 2024
    Configuration menu
    Copy the full SHA
    a67baf0 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2024

  1. Various fixes toward parity with HF impl 

    Fixed logic and include mask in what is returned from
 _preserve_last_target_len_logits.  Fixed padding, cont_tok tracking, and
 removed one-token continuation caching
    @chimezie
    chimezie committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    f6e2e20 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/mlx' into mlx

    @chimezie
    chimezie committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    4349b50 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'EleutherAI:main' into mlx

    @chimezie
    chimezie authored Nov 30, 2024
    Configuration menu
    Copy the full SHA
    853db9f View commit details
    Browse the repository at this point in the history

  4. Calculate greedy tokens off logits not log probs

    @chimezie
    chimezie committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    78fc03e View commit details
    Browse the repository at this point in the history

  5. Swapped back for no other reason than because that is how it is in HF… 

    … impl
    @chimezie
    chimezie committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    0df42c1 View commit details
    Browse the repository at this point in the history