8 marketing card #60
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import React from "react"; | ||
|
|
||
| const Card = ({ icon, title, children }) => { | ||
| return ( | ||
| <div className='p-4 mb-4 w-1/3 flex justify-center items-center'> | ||
| <div className='text-center '> | ||
| {icon} | ||
| <h3 className='p-2 font-bold'>{title}</h3> | ||
| {children} | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default Card; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| import React from "react"; | ||
| import Card from "./Card"; | ||
|
|
||
| const SectionWithCards = () => { | ||
| return ( | ||
| <section className='bg-gray-100 p-8 border w-5/6 mx-auto text-center my-6 '> | ||
| <h2 className='text-2xl font-bold mb-8 '>Section Title</h2> | ||
|
|
||
| <div className='flex flex-wrap items-center mx-4 border-red'> | ||
| <div className='w-full md:w-1/3 px-4 mb-4 flex flex-col items-center justify-center border border-blue-600'> | ||
| <Card> | ||
| <img | ||
|
There was a problem hiding this comment. to add to what @ismail-benlaredj said it's recommended you use Image when importing images and import it from "Next" for built-in optimization instead of using img . |
||
| className='pb-4' | ||
| src='./marketing-icons/sec1.png' | ||
| alt='Icon' | ||
| /> | ||
| <h3 className='text-xl font-bold mb-2'>Card 1 Title</h3> | ||
| <p>Card 1 Content</p> | ||
| </Card> | ||
| </div> | ||
|
|
||
| <div className='w-full md:w-1/3 px-4 mb-4 bg-white flex flex-col items-center justify-center border border-blue-600'> | ||
| <Card> | ||
| <img | ||
| className='pb-4' | ||
| src='./marketing-icons/sec1.png' | ||
| alt='Icon' | ||
| /> | ||
| <h3 className='text-xl font-bold mb-2'>Card 1 Title</h3> | ||
| <p>Card 1 Content</p> | ||
| </Card> | ||
| </div> | ||
| <div className='w-full md:w-1/3 px-4 mb-4 bg-white flex flex-col items-center justify-center border border-blue-600'> | ||
| <Card> | ||
| <img | ||
| className='pb-4' | ||
| src='./marketing-icons/sec1.png' | ||
| alt='Icon' | ||
| /> | ||
| <h3 className='text-xl font-bold mb-2'>Card 1 Title</h3> | ||
| <p>Card 1 Content</p> | ||
| </Card> | ||
| </div> | ||
| </div> | ||
| </section> | ||
| ); | ||
| }; | ||
|
|
||
| export default SectionWithCards; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, Mohamed! 👏 I really like the sectionWithCard.
The design includes sections with different numbers of cards, some with 3 cards and others with 4 If you modify the sectionWithCard component to accept elements as children, it will provide more flexibility.
Also, consider removing the borders .
There seems to be a minor issue in the description – please check the screenshot provided for clarification.