-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8 marketing card #60
8 marketing card #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, Mohamed! 👏 I really like the sectionWithCard.
The design includes sections with different numbers of cards, some with 3 cards and others with 4 If you modify the sectionWithCard component to accept elements as children, it will provide more flexibility.
Also, consider removing the borders .
There seems to be a minor issue in the description – please check the screenshot provided for clarification.
<div className='flex flex-wrap items-center mx-4 border-red'> | ||
<div className='w-full md:w-1/3 px-4 mb-4 flex flex-col items-center justify-center border border-blue-600'> | ||
<Card> | ||
<img |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to add to what @ismail-benlaredj said it's recommended you use Image when importing images and import it from "Next" for built-in optimization instead of using img .
); | ||
}; | ||
|
||
export default SectionWithCards; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job.
The component is neatly structured, making it easy to understand. |
Great job. |
Changes Made:
1 Created a new component SectionWithCards for displaying marketing cards.
2 Added a Card component for individual card items.