Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8 marketing card #60

Merged
merged 5 commits into from
Oct 23, 2023
Merged

8 marketing card #60

merged 5 commits into from
Oct 23, 2023

Conversation

mohamed-cheraitia
Copy link
Collaborator

Changes Made:

1 Created a new component SectionWithCards for displaying marketing cards.
2 Added a Card component for individual card items.

@mohamed-cheraitia mohamed-cheraitia linked an issue Oct 19, 2023 that may be closed by this pull request
@ismail-benlaredj ismail-benlaredj changed the base branch from main to dev October 20, 2023 10:26
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, Mohamed! 👏 I really like the sectionWithCard.

The design includes sections with different numbers of cards, some with 3 cards and others with 4 If you modify the sectionWithCard component to accept elements as children, it will provide more flexibility.

Also, consider removing the borders .

There seems to be a minor issue in the description – please check the screenshot provided for clarification.

Screenshot 2023-10-20 at 11-40-18 Screenshot

@darinetag darinetag self-requested a review October 20, 2023 11:41
<div className='flex flex-wrap items-center mx-4 border-red'>
<div className='w-full md:w-1/3 px-4 mb-4 flex flex-col items-center justify-center border border-blue-600'>
<Card>
<img
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to add to what @ismail-benlaredj said it's recommended you use Image when importing images and import it from "Next" for built-in optimization instead of using img .

);
};

export default SectionWithCards;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job.

@mohamed-cheraitia
Copy link
Collaborator Author

The component is neatly structured, making it easy to understand.
Icons, titles, and content are rendered correctly within each card.
The section is responsive, ensuring a good user experience on various devices.
If you've tested the component thoroughly and everything is functioning as expected, it's ready for merging. Well done!

@darinetag darinetag added the Feature Request 🚀 New feature or request label Oct 21, 2023
@darinetag
Copy link
Collaborator

Great job.

@ismail-benlaredj ismail-benlaredj merged commit 6725cca into dev Oct 23, 2023
3 checks passed
@ismail-benlaredj ismail-benlaredj deleted the 8-marketing-card branch October 27, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request 🚀 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marketing card
3 participants