Endpoint to search for github user #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR for review
npm run eslintto find errors in code syntax/formatnpm run eslint:fixto fix all auto-fixable errors in source code and auto-format with prettierWhat does this PR do?
Fixes #378
Summarise the main tasks handled in the pull request
endpoint /api/github/user/ return json object with github user's information
Description of Task to be completed?
Describe (in detail) what the task completed in the pull request does as per the relevant task
How should this be manually tested?
Give bullet point instructions on how to setup the code and test it manually (Assume no prior experience on JS or code)
Any background context you want to provide?
Any pertinent information that should be considered
What is the link to the issue on Github?
Issue #240
Questions:
If something is unclear or you want some questions to be addressed by your peers, mention them here