Fix navigation show on mobile per display type

[omurilo]

This PR fix the feature introduced on #290 on mobile devices, and add a feature to use globalDisplay for define the default behaviour of renderization to routes.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
zudoku-www	⬜️ Skipped (Inspect)		Oct 27, 2024 5:18pm

[vercel]

@omurilo is attempting to deploy a commit to the Zuplo WWW Team on Vercel.

A member of the Team first needs to authorize it.

[mosch]

Hey @omurilo thanks for your contribution 👏 Great catch that the top-navigation item where not hidden on mobile yet.

This PR contains a lot of changes, and some of them have very far-reaching effects.
In order to get your changes in, lets move step by step.

I created this PR #297 that only contains a fix to hide the items on mobile as well.

Other things is see in this PR:

• Introduce a globalDisplay to change the default behaviour of top navigation
• Added missing openid auth type (great change, but 🙏 please get it in a seperate PR)
• Hide all sidebar items if the top navigation item in hidden

Can you give us some details on the use-case so we can find an appropriate solution for want to achieve?

[omurilo]

hey @mosch, ok no problem on separate the PR.

About openid types I can made a new PR for fix this, no problem.

About globalDisplay I think it a great introduction to make possible define the default behavior for more than one item and then set a anon display in an specific route for example.

About hide all sidebar items when top navigation is hidden, I think it a default behavior for this functionality, if I set a topNavigation display for the id docs for example, I don't want the user have access to the sidebar of /docs, don't make sense it view an item it he doesn't access.

[mosch]

About hide all sidebar items when top navigation is hidden, I think it a default behavior for this functionality, if I set a topNavigation display for the id docs for example, I don't want the user have access to the sidebar of /docs, don't make sense it view an item it he doesn't access.

I understand. This option is not ment do implement permission, but only to controll visiblity. It would be the responsibility of the page to implement the permssion. So this configuration should be on the page, not on the menu.

Can you tell me about what you're trying to build – so it would be easier for us to come up with a recommended solution!

[omurilo]

About hide all sidebar items when top navigation is hidden, I think it a default behavior for this functionality, if I set a topNavigation display for the id docs for example, I don't want the user have access to the sidebar of /docs, don't make sense it view an item it he doesn't access.

I understand. This option is not ment do implement permission, but only to controll visiblity. It would be the responsibility of the page to implement the permssion. So this configuration should be on the page, not on the menu.

Can you tell me about what you're trying to build – so it would be easier for us to come up with a recommended solution!

If the permission is only on the page, the menu is always visible and this isn't the acceptable behavior in my opinion.