Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated #39: Use stateless flag from toolkit.ini it is present to override value in $_options array #173

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Updated #39: Use stateless flag from toolkit.ini it is present to override value in $_options array #173

wants to merge 5 commits into from

Commits on Nov 12, 2021

  1. Rebasing: Use stateless flag from toolkit.ini it is present to overri… 

    …de value in

$_options array.  Add to constructor by adding to the array in
getOptionalParams.

Change default stateless flag to flase in the toolkit.ini to match
existing functionality

Add second stateless flag for XML toolkit.  Check if call is being made from compatibility wrapper and use appropriate stateless flag.
    @Scott-Cam @NattyNarwhal
    Scott-Cam authored and NattyNarwhal committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    d37e86b View commit details
    Browse the repository at this point in the history

  2. Rebasing and re-applying changes 

    (Calvin edit: Don't add "stateless", fixed this while resolving rebase
conflict)
    @NattyNarwhal
    NattyNarwhal committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    36c0386 View commit details
    Browse the repository at this point in the history

  3. Revert back to original behaviour that would work 

    And document it
    @NattyNarwhal
    NattyNarwhal committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    7eb3ecb View commit details
    Browse the repository at this point in the history

  4. Flip this to match original semantics 

    Otherwise would be breaking change for new installs
    @NattyNarwhal
    NattyNarwhal committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    67c7fc1 View commit details
    Browse the repository at this point in the history

  5. The names are different, so special handling

    @NattyNarwhal
    NattyNarwhal committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    b5977d8 View commit details
    Browse the repository at this point in the history