Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hash issues #28

Merged
merged 8 commits into from
Sep 7, 2024
Merged

Fix hash issues #28

merged 8 commits into from
Sep 7, 2024

Conversation

yaito3014
Copy link
Owner

fixes #25, fixes #27

saki7

This comment was marked as resolved.

Sign in to view

@yaito3014 yaito3014 requested a review from saki7 September 7, 2024 00:50
saki7

This comment was marked as resolved.

Sign in to view

@saki7 saki7 added bug Something isn't working enhancement New feature or request labels Sep 7, 2024
@yaito3014
Copy link
Owner Author

should proxy_hash.hpp and string_hash.hpp be in yk/hash directory?

@saki7
Copy link
Collaborator

saki7 commented Sep 7, 2024

should proxy_hash.hpp and string_hash.hpp be in yk/hash directory?

Good catch, they should indeed be in the directory as you said.

saki7
saki7 approved these changes Sep 7, 2024
View reviewed changes
Copy link
Collaborator

@saki7 saki7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK you can merge this anytime soon, if you have pending cosmetic changes feel free to push it too.

@saki7 saki7 removed their assignment Sep 7, 2024
@yaito3014 yaito3014 merged commit 00aab0c into main Sep 7, 2024
8 checks passed
@yaito3014 yaito3014 deleted the fix-hash branch September 7, 2024 01:18
@saki7
Copy link
Collaborator

saki7 commented Sep 7, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saki7 saki7 saki7 approved these changes

Assignees

@yaito3014 yaito3014

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hash related bug/regression since #26 Too much constexpr in hashers
2 participants
@yaito3014 @saki7