reorganize hash header (again) and add hash_range #26

yaito3014 · 2024-09-06T09:19:10Z

fixes #24

include/yk/hash/hash_value_for.hpp

include/yk/hash/range.hpp

saki7 · 2024-09-06T10:50:51Z

Thanks!
I will use this and if I find any issues I will report then.

saki7 · 2024-09-06T10:52:55Z

@yaito3014 Could you add test for

yk::hash_combine(val, rng, val)

This reverts commit 1ae9e25.

saki7 · 2024-09-06T11:12:26Z

𝑺𝒖𝒑𝒆𝒓 𝑻𝒉𝒂𝒏𝒌𝒔

yaito3014 added 4 commits September 6, 2024 18:16

reorganize hash header (again) and add hash_range

1ec07eb

resolve circular dependency

5ff60cf

use hash_combine instead of hash_range

e000aae

remove no longer neccesary forward declaration

38e1e5c

saki7 requested changes Sep 6, 2024

View reviewed changes

include/yk/hash/hash_value_for.hpp Outdated Show resolved Hide resolved

include/yk/hash/range.hpp Outdated Show resolved Hide resolved

yaito3014 added 3 commits September 6, 2024 19:22

move forward declaration header, enable hashing empty range

3b91f32

make hash_value_for depends on Boost

3409be1

fix hash_combine related operations

1ae9e25

yaito3014 requested a review from saki7 September 6, 2024 10:42

IWYU

952ad9f

saki7 approved these changes Sep 6, 2024

View reviewed changes

yaito3014 added 3 commits September 6, 2024 20:01

add test

9d74dfa

Revert "fix hash_combine related operations"

5f1e957

This reverts commit 1ae9e25.

yet another fix

8a4778f

saki7 merged commit d1d6b59 into main Sep 6, 2024
8 checks passed

saki7 deleted the range-based-hash branch September 6, 2024 11:12

saki7 added bug Something isn't working enhancement New feature or request labels Sep 7, 2024

Provide feedback