Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for runInTerminal request #966

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

zobo
Copy link
Contributor

@zobo zobo commented Jun 30, 2024

Support for console option with internalConsole, integratedTerminal and externalTerminal options

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 26.00000% with 37 lines in your changes missing coverage. Please review.

Project coverage is 66.13%. Comparing base (3025d1f) to head (b94ace2).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/terminal.ts 19.23% 21 Missing ⚠️
src/phpDebug.ts 27.27% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
- Coverage   67.10%   66.13%   -0.97%     
==========================================
  Files          14       14              
  Lines        1988     2064      +76     
  Branches      393      415      +22     
==========================================
+ Hits         1334     1365      +31     
- Misses        654      699      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zobo zobo linked an issue Jun 30, 2024 that may be closed by this pull request
@zobo
Copy link
Contributor Author

zobo commented Jul 1, 2024

The dilemma here is that it's not trivial to track the spawned process and catch the exit event - and kill the right process.

@zobo zobo changed the base branch from main to next July 13, 2024 23:04
Base automatically changed from next to main July 15, 2024 21:20
@zobo zobo mentioned this pull request Jul 16, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runInTerminal request
1 participant