Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java detection from java.jdt.ls.java.home as primary #611

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

sciencewhiz
Copy link
Contributor

Fixes #579
Companion to wpilibsuite/WPILibInstaller-Avalonia#345

Keeps deprecated java.home old setting as secondary

@sciencewhiz sciencewhiz changed the title Add java detection from java.jdt.ls.java.home ss primary Add java detection from java.jdt.ls.java.home as primary Aug 28, 2023
@PeterJohnson PeterJohnson merged commit 273641d into wpilibsuite:main Aug 30, 2023
5 checks passed
wpineth added a commit to wpineth/vscode-wpilib that referenced this pull request Mar 29, 2024
sciencewhiz added a commit to sciencewhiz/vscode-wpilib that referenced this pull request Aug 8, 2024
java.home is deprecated. Corollary to wpilibsuite#611
sciencewhiz added a commit to sciencewhiz/vscode-wpilib that referenced this pull request Aug 8, 2024
java.home is deprecated. Corollary to wpilibsuite#611
PeterJohnson pushed a commit that referenced this pull request Aug 14, 2024
java.home is deprecated. Corollary to #611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vscode-wpilib not respecting java home setting due to java.home being deprecated
2 participants