Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to all pipeline tabs #4421

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add icons to all pipeline tabs #4421

wants to merge 1 commit into from

Conversation

xoxys
Copy link
Member

@xoxys xoxys commented Nov 20, 2024

I would like to add icons to all tabs in pipeline view (and later on also in other views). In my opinion it looks better and results in a consistent look, especially on mobile where tabs are displayed in vertically.

@woodpecker-ci/maintainers as this might be another controversial design decision, please vote on the initial post of this PR with 👍 and 👎

Desktop:
image

Mobile:

@xoxys xoxys marked this pull request as draft November 20, 2024 21:54
@pat-s
Copy link
Contributor

pat-s commented Nov 20, 2024

I like the idea but don't like the icon choice in the screenshot too much.

Thanks for starting with a poll right away. It might be that we need a separate one for each icon 😅️

@pat-s
Copy link
Contributor

pat-s commented Nov 20, 2024

@xoxys
Copy link
Member Author

xoxys commented Nov 20, 2024

Thanks for the feedback.

I had something in mind while choosing exactly these icons. I was looking for icons that somehow fit together semantically. I started with a stack of sheets aka workflows/tasks. A single sheet from the stack should symbolize a part of the config. Thats why I chose the paper sheet icons for the config (I definetly want to avoid using the gear as this is used for settings already) and the config parsing issues. The last icon for debugging was the closest I found that looks like "inspecting a sheet" (aka workflow/task). Last but not least all icons have a similar shape to avoid a too chaotic and distracting look.

Sure there might be "better" icons for each tab but I dont know if that should be the only criteria but Im also not a professional ui designer :)

Nevertheless Im not interested in months of discussions for single icons we have too much of them. It that is the outcome thats totally fine but then Ill leave this task to someone else :)

@pat-s
Copy link
Contributor

pat-s commented Nov 21, 2024

I had something in mind while choosing exactly these icons. I was looking for icons that somehow fit together semantically.

OK, didn't know that :)

Let's see what others think!

m also not a professional ui designer :)

None of us is, so no worries. I guess most people just follow their gut feeling which might be more or less matching with others.

@xoxys
Copy link
Member Author

xoxys commented Nov 21, 2024

OK, didn't know that :)

How could you :) Don't want to blame anyone. If you don't like the icons, that perfectly fine.

@xoxys xoxys force-pushed the pipeline-tabs-icons branch 2 times, most recently from 0d88b2b to 7e3efb9 Compare November 22, 2024 09:52
@qwerty287
Copy link
Contributor

qwerty287 commented Nov 22, 2024

What about other tab usages? Repo, settings etc.? Can we add icons there as well for consistency or is there a reason why this should only be done for the pipeline view?

I'm fine with the icons except the warnings one which looks a bit odd as these are two parts not directly connected (the sheet and the exclamation mark).

@xoxys
Copy link
Member Author

xoxys commented Nov 22, 2024

As written above just wanted to get a consensus first. But yes I planned to add icons to all tabs (if we can find an agreememt for particular icons)

@zc-devs
Copy link
Contributor

zc-devs commented Nov 23, 2024

Do you use the same icon for Errors tab as for Warnings?
There is no colors (yellow, red) in those icons now, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants