-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons to all pipeline tabs #4421
base: main
Are you sure you want to change the base?
Conversation
I like the idea but don't like the icon choice in the screenshot too much. Thanks for starting with a poll right away. It might be that we need a separate one for each icon 😅️ |
Here are some possible alternatives up for discussion: |
Thanks for the feedback. I had something in mind while choosing exactly these icons. I was looking for icons that somehow fit together semantically. I started with a stack of sheets aka workflows/tasks. A single sheet from the stack should symbolize a part of the config. Thats why I chose the paper sheet icons for the config (I definetly want to avoid using the gear as this is used for settings already) and the config parsing issues. The last icon for debugging was the closest I found that looks like "inspecting a sheet" (aka workflow/task). Last but not least all icons have a similar shape to avoid a too chaotic and distracting look. Sure there might be "better" icons for each tab but I dont know if that should be the only criteria but Im also not a professional ui designer :) Nevertheless Im not interested in months of discussions for single icons we have too much of them. It that is the outcome thats totally fine but then Ill leave this task to someone else :) |
OK, didn't know that :) Let's see what others think!
None of us is, so no worries. I guess most people just follow their gut feeling which might be more or less matching with others. |
How could you :) Don't want to blame anyone. If you don't like the icons, that perfectly fine. |
0d88b2b
to
7e3efb9
Compare
7e3efb9
to
74e07f7
Compare
What about other tab usages? Repo, settings etc.? Can we add icons there as well for consistency or is there a reason why this should only be done for the pipeline view? I'm fine with the icons except the warnings one which looks a bit odd as these are two parts not directly connected (the sheet and the exclamation mark). |
As written above just wanted to get a consensus first. But yes I planned to add icons to all tabs (if we can find an agreememt for particular icons) |
Do you use the same icon for Errors tab as for Warnings? |
I would like to add icons to all tabs in pipeline view (and later on also in other views). In my opinion it looks better and results in a consistent look, especially on mobile where tabs are displayed in vertically.
@woodpecker-ci/maintainers as this might be another controversial design decision, please vote on the initial post of this PR with 👍 and 👎
Desktop:
Mobile: