dilithium fixes for FIPS 204 draft mode #8207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm pretty sure the current PRB failures aren't related to this PR, as they all seem to have to do with CRL stuff which I think is temporarily broken? |
Correct. Fixes are in #8182 |
|
Retest this please. CRL issues |
bigbrett
force-pushed
the
dilithium-nightly-fixes
branch
from
fdf5300
to
cceeb77
Compare
dgarske
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #8177, adding fixes for broken Dilithium nightly tests that use FIPS 204 draft mode. Prevents draft mode from using OID autodetection and updates documentation.
Also add the auto-generated error code trace macros to .gitignore so it doesn't show up as unstaged when generated