Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20241113-WC_THREADSHARED #8184

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Conversation

douzzer
Copy link
Contributor

@douzzer douzzer commented Nov 13, 2024

rename WOLFSSL_GLOBAL to WC_THREADSHARED, and refactor mutex handling in src/sniffer.c for consistency and correctness, also adding gating on !SINGLE_THREADED for efficiency;

add wc_static_assert in wolfcrypt/test/test.h to assure that WC_TEST_RET_ENC() can correctly handle all error codes.

tested with wolfssl-multi-test.sh ... commit-test-potpourri super-quick-check

also tested with

./configure --quiet --disable-jobserver --enable-fips=disabled --enable-all --disable-all-osp --enable-sniffer --enable-singlethreaded --disable-crl-monitor
./configure --quiet --disable-jobserver --enable-fips=disabled --enable-all --enable-sniffer

@douzzer
Copy link
Contributor Author

douzzer commented Nov 14, 2024

retest this please

@douzzer douzzer assigned wolfSSL-Bot and unassigned douzzer Nov 14, 2024
@douzzer
Copy link
Contributor Author

douzzer commented Nov 14, 2024

not ready for merge yet -- offline testing by @lealem47 found bug(s).

… in src/sniffer.c for consistency and correctness, also adding gating on !SINGLE_THREADED for efficiency;

add wc_static_assert in wolfcrypt/test/test.h to assure that WC_TEST_RET_ENC() can correctly handle all error codes.
lealem47
lealem47 previously approved these changes Nov 15, 2024
dgarske
dgarske previously approved these changes Nov 15, 2024
…HREADED, as it breaks existing build tests. fix more later.
@douzzer douzzer dismissed stale reviews from dgarske and lealem47 via 469c410 November 15, 2024 00:23
@douzzer
Copy link
Contributor Author

douzzer commented Nov 15, 2024

should be ready for merge now, but this effort uncovered nondeterministic bugs in snifferTest that need attention. @lealem47 repro'd and knows the details.

@dgarske dgarske merged commit 8fe7d10 into wolfSSL:master Nov 15, 2024
143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants